Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No images in dest folder #85

Open
andrewerrico opened this issue Dec 12, 2016 · 6 comments
Open

No images in dest folder #85

andrewerrico opened this issue Dec 12, 2016 · 6 comments

Comments

@andrewerrico
Copy link

I just updated node and npm and can't get my favicons working proplerly. The grunt task runs, but no images end up in the destination folder.

Any ideas?

@japrescott
Copy link

have experienced the same behavior with node 7.2.1 node 6.x worked without an issue.

@Ambient-Impact
Copy link

This still seems to be the case with node 8.4.0. D:

@Ambient-Impact
Copy link

Super late update: turns out that this is caused by the use of the legacy convert utility in this plug-in, which isn't installed by default with ImageMagick unless you check that checkbox in the installer. Installing with that seems to make it work correctly, with all the images correctly generated.

@japrescott
Copy link

@Ambient-Impact I made a fork of this repo with extended functionality if you are interested; https://github.com/japrescott/grunt-favicons

@Ambient-Impact
Copy link

Ambient-Impact commented Dec 4, 2019

@japrescott Awesome, just started using it. Planning to publish it on NPM as a separate package from the original at some point?

Edit: while this is arguably a low risk security issue, any chance of switching from sync-exec to child_process.execSync as this NPM security advisory recommends? I'd open an issue on your repo but you have issues disabled, it seems.

@japrescott
Copy link

@Ambient-Impact thank you. I enabled creating tickets and will be publishing it to npm as different people seem to be using it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants