Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Change in Badge Object #722

Open
BecTome opened this issue Jun 6, 2023 · 2 comments · May be fixed by #725
Open

New Change in Badge Object #722

BecTome opened this issue Jun 6, 2023 · 2 comments · May be fixed by #725

Comments

@BecTome
Copy link

BecTome commented Jun 6, 2023

In Badgr website they have changed the way they send the badge json. Now, there aren't entity_type nor extensions.

The following error is raised:

packages\badgr_lite\models.py", line 68, in _check_missing_but_required
raise exceptions.RequiredAttributesMissingError(
badgr_lite.exceptions.RequiredAttributesMissingError: extensions, entity_type

Proposed solution that worked for me: change model for Badge object:
1- go to models.py
2- delete from REQUIRED_JSON the strings "entityType" and "extensions"

Now it works

@BecTome
Copy link
Author

BecTome commented Jun 6, 2023

It's needed to delete issuerOpenBadgeId too. At least for me.

@glenjarvis
Copy link
Owner

@BecTome I ran into the same issue when doing a major update recently (not yet released). So, excellent bug report. I also did the same approach that you did.

If you wish to put a PR in, I'll merge it tonight. Otherwise, I'll make the same change and get it PRd and merged into develop tonight. There's also a fix for the command line being missed.

I have a dependency update refresh that will take longer. But, I can get these two changes fixed today for the dependencies that are here now.

@glenjarvis glenjarvis linked a pull request Jun 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants