Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest cleanhttp.go commit has broken build #262

Closed
snowleopard75 opened this issue Feb 12, 2017 · 8 comments
Closed

Latest cleanhttp.go commit has broken build #262

snowleopard75 opened this issue Feb 12, 2017 · 8 comments

Comments

@snowleopard75
Copy link

snowleopard75 commented Feb 12, 2017

See hashicorp/go-cleanhttp@a459706:

When building master:

docker build .

Fails with:

# github.com/hashicorp/go-cleanhttp
../../hashicorp/go-cleanhttp/cleanhttp.go:29: unknown http.Transport field 'DialContext' in struct literal
../../hashicorp/go-cleanhttp/cleanhttp.go:30: unknown http.Transport field 'MaxIdleConns' in struct literal
../../hashicorp/go-cleanhttp/cleanhttp.go:31: unknown http.Transport field 'IdleConnTimeout' in struct literal
The command '/bin/sh -c cd /src && ./build.sh "$(cat VERSION)"' returned a non-zero code: 2

It seems as though the latest commit has introduced 1.7+ dependencies which are not backwards compatible with 1.6, the latest supported package in alpine 3.4.

@snowleopard75
Copy link
Author

snowleopard75 commented Feb 12, 2017

FWIW, I just tried using alpine:3.5 with go 1.7.3 to see what happens, and while it builds, launching logspout ends up giving me this error, which might be related to fsouza/go-dockerclient#621:

# logspout v3.2-dev by gliderlabs
# adapters: syslog tcp udp tls raw
# options : debug:true persist:/mnt/routes
# jobs    : http[routes,logs]:80 pump routes
# routes  : none
2017/02/12 18:22:35 pump.Run(): using inactivity timeout:  0s
2017/02/12 18:22:45 pump ended: Get http://unix.sock/containers/json?: dial tcp: lookup unix.sock on 127.0.0.11:53: read udp 127.0.0.1:42810->127.0.0.11:53: i/o timeout

@mccricardo
Copy link

Having the same issue.

@amitripshtos
Copy link

same, I really love this project but it breaks my CI constantly when I'm building this image :(

@richard-mauri
Copy link

I have a project that depends on hashicorp vault that is now broken.
I am building with go 1.7.4
Are we both victims of a bad hashi commit; how can we defend ourselves?

vagrant@vaultaccess-host:/vaultaccess$ go version
go version go1.7.4 linux/amd64
vagrant@vaultaccess-host:
/vaultaccess$
vagrant@vaultaccess-host:~/vaultaccess$ ./build.sh

github.com/hashicorp/vault/vendor/github.com/hashicorp/go-cleanhttp

../github.com/hashicorp/vault/vendor/github.com/hashicorp/go-cleanhttp/cleanhttp.go:29: unknown http.Transport field 'DialContext' in struct literal
../github.com/hashicorp/vault/vendor/github.com/hashicorp/go-cleanhttp/cleanhttp.go:30: unknown http.Transport field 'MaxIdleConns' in struct literal
../github.com/hashicorp/vault/vendor/github.com/hashicorp/go-cleanhttp/cleanhttp.go:31: unknown http.Transport field 'IdleConnTimeout' in struct literal

@rosteroster
Copy link

make sure you're using a supported version of Go. Can confirm that I was getting this error in Go 1.6 and fixed in Go 1.7

@michaelshobbs
Copy link
Member

@kirkbgh @richard-mauri @amitripshtos @mccricardo We now test builds on every merge and I think this is ok now. Can someone confirm this is fixed out in the wild?

@mccricardo
Copy link

@michaelshobbs I was able to build it successfully.

@smartb-dev
Copy link

We are seeing this exact error on Go 1.8, building the Circonus Protocol Observer:

# github.com/hashicorp/go-cleanhttp
    tmp/protocol_observer/src/github.com/hashicorp/go-cleanhttp/cleanhttp.go:30: unknown http.Transport field 'DialContext' in struct literal
    tmp/protocol_observer/src/github.com/hashicorp/go-cleanhttp/cleanhttp.go:31: unknown http.Transport field 'MaxIdleConns' in struct literal
    tmp/protocol_observer/src/github.com/hashicorp/go-cleanhttp/cleanhttp.go:32: unknown http.Transport field 'IdleConnTimeout' in struct literal
    # github.com/hashicorp/go-cleanhttp
    ../../../hashicorp/go-cleanhttp/cleanhttp.go:30: unknown http.Transport field 'DialContext' in struct literal
    ../../../hashicorp/go-cleanhttp/cleanhttp.go:31: unknown http.Transport field 'MaxIdleConns' in struct literal
    ../../../hashicorp/go-cleanhttp/cleanhttp.go:32: unknown http.Transport field 'IdleConnTimeout' in struct literal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants