Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERP: Modifications in registration form #3127

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

ERP: Modifications in registration form #3127

wants to merge 15 commits into from

Conversation

akanshaaa19
Copy link
Member

target issue is #3105

@akanshaaa19 akanshaaa19 self-assigned this Nov 4, 2024
@akanshaaa19 akanshaaa19 changed the title Enhancement/erp ERP: Modifications in registration form Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3127--glific-frontend.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 07:54 Inactive
@cypress Cypress
Copy link

cypress bot commented Nov 4, 2024 •
edited
Loading

Glific    Run #5370

Run Properties:  status check passed Passed #5370  •  git commit b1050d21f1 ℹ️: Merge 0d9016dfeb8282e506b58310780fd049f5d54869 into f2e2f62849f1f246e9605fc19b6a...
Project Glific
Branch Review enhancement/erp
Run status status check passed Passed #5370
Run duration 25m 51s
Commit git commit b1050d21f1 ℹ️: Merge 0d9016dfeb8282e506b58310780fd049f5d54869 into f2e2f62849f1f246e9605fc19b6a...
Committer Akansha Sakhre
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 04:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 07:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 10:50 Inactive
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.17978% with 39 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (f2e2f62) to head (0d9016d).

Files with missing lines Patch % Lines
...s/Organization/Onboarding/Steps/PaymentDetails.tsx 52.63% 8 Missing and 1 partial ⚠️
...iners/Organization/Onboarding/Steps/OrgDetails.tsx 55.55% 5 Missing and 3 partials ⚠️
...Organization/Onboarding/Steps/SigningAuthority.tsx 50.00% 7 Missing and 1 partial ⚠️
.../Organization/Onboarding/Steps/PlatformDetails.tsx 46.15% 6 Missing and 1 partial ⚠️
.../Organization/Onboarding/FormLayout/FormLayout.tsx 0.00% 3 Missing and 1 partial ⚠️
.../Organization/Onboarding/Steps/Address/Address.tsx 83.33% 0 Missing and 2 partials ⚠️
...nization/Onboarding/PaymentType/PaymentOptions.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3127      +/-   ##
==========================================
- Coverage   81.70%   81.60%   -0.10%     
==========================================
  Files         328      329       +1     
  Lines       10471    10523      +52     
  Branches     2219     2228       +9     
==========================================
+ Hits         8555     8587      +32     
- Misses       1304     1321      +17     
- Partials      612      615       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 linked an issue Nov 6, 2024 that may be closed by this pull request
ERPnext: Modify the registration form #3105
Open
@github-actions github-actions bot temporarily deployed to pull request November 6, 2024 07:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 6, 2024 11:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 15:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 8, 2024 15:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 11, 2024 08:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 09:05 Inactive
kurund
kurund requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@kurund kurund left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19

  1. We need better error handling. If someone tries to register and org does not exist the form fails silently. We should at least show some helpful message.

  2. Can you also fix failing unit tests?

  3. I am also trying to register a new org: Example NGO and the backend is failing with an error. Note that Example NGO has been added to Frappe.

Let's discuss.

src/App.tsx Outdated Show resolved Hide resolved
@akanshaaa19
Copy link
Member Author

@akanshaaa19

  1. We need better error handling. If someone tries to register and org does not exist the form fails silently. We should at least show some helpful message.
  2. Can you also fix failing unit tests?
  3. I am also trying to register a new org: Example NGO and the backend is failing with an error. Note that Example NGO has been added to Frappe.

Let's discuss.

  1. There is error handling for when org doesn't exist in erp.
image 2. done 3. yes amisha is looking into that

@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 04:46 Inactive
@kurund
Copy link
Contributor

kurund commented Nov 13, 2024

@akanshaaa19

Can you update the message to: "Example organization not found". Please contact the Glific support team.

@akanshaaa19
Copy link
Member Author

akanshaaa19 commented Nov 13, 2024 •
edited
Loading

@akanshaaa19

Can you update the message to: "Example organization not found". Please contact the Glific support team.

sure, @AmishaBisht will be doing that from the BE
@kurund

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurund kurund kurund requested changes

Assignees

@akanshaaa19 akanshaaa19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERPnext: Modify the registration form
2 participants
@akanshaaa19 @kurund