Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit of latency metrics #184

Open
random-user-00 opened this issue Jul 30, 2020 · 2 comments
Open

Unit of latency metrics #184

random-user-00 opened this issue Jul 30, 2020 · 2 comments

Comments

@random-user-00
Copy link

What is the exact unit for latency metrics? It is not in documentation or Metrics type description.
e.g.
gluster_volume_profile_fop_avg_latency
gluster_volume_profile_fop_max_latency

I assume these values are in milliseconds, but having some description in metric description would be useful.

@random-user-00 random-user-00 changed the title Unit for latency metrics Unit of latency metrics Jul 30, 2020
@limiao2008
Copy link

@random-user-00 enable collectors.gluster_volume_profile contain gluster_volume_profile_fop_avg_latency and gluster_volume_profile_fop_max_latency

[collectors.gluster_volume_profile]
name = "gluster_volume_profile"
sync-interval = 5
disabled = fals

you can look at line 141 of https://github.com/gluster/gluster-prometheus/blob/ec6f41bc9500a5c1ce718fa5b7466ee5552417d5/gluster-exporter/metric_volume.go
e

.....
	glusterVolumeProfileFopAvgLatency = registerExportedGaugeVec(Metric{
		Namespace: "gluster",
		Name:      "volume_profile_fop_avg_latency",
		Help:      "Cumulative FOP avergae latency",
		LongHelp:  "",
		Labels:    volumeProfileFopInfoLabels,
	}, &volumeProfileGaugeVecs)

....
func init() {
	registerMetric("gluster_volume_heal", healCounts)
	registerMetric("gluster_volume_profile", profileInfo)
}

@limiao2008
Copy link

Others need to be noted see it #147 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants