Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt for confirmation before exiting dialog #72

Closed
glutanimate opened this issue Jun 28, 2018 · 0 comments · May be fixed by #127
Closed

Prompt for confirmation before exiting dialog #72

glutanimate opened this issue Jun 28, 2018 · 0 comments · May be fixed by #127
Assignees
@glutanimate
Labels
enhancement New feature or request
Milestone
1.3 stable

Comments

@glutanimate
Copy link
Owner

This is even more important now that closing the parent window (AddCards / Browser) also closes the I/O Editor.
@glutanimate glutanimate self-assigned this Jun 28, 2018
@glutanimate glutanimate added the enhancement New feature or request label Jun 28, 2018
@glutanimate glutanimate modified the milestones: 1.3 beta, 1.3 stable Jun 29, 2018
5hir0kur0 added a commit to 5hir0kur0/image-occlusion-enhanced that referenced this issue Jan 4, 2020
@5hir0kur0
Confirmation popup before closing the occlusion editor
65ef508 
Fixes glutanimate#72.
Note that this confirmation popup is shown in some cases where I don't
think it's necessary. If the user adds occlusions, clicks on one of the
buttons to create the cards and then closes the editor dialog they are
prompted for confirmation.
The only way I can think of to prevent this is to reset the svg-edit
undo stack when the user clicks on the button, but I'm not sure if
that's acceptable.
@5hir0kur0 5hir0kur0 mentioned this issue Jan 4, 2020
Open
13 tasks
@glutanimate glutanimate mentioned this issue Jun 1, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glutanimate glutanimate

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3 stable
Development

Successfully merging a pull request may close this issue.

Fix issue #72 (Prompt for confirmation before exiting dialog) 5hir0kur0/image-occlusion-enhanced
1 participant
@glutanimate