From bc1b486c2121ea77476a8c704e737ed3a6369594 Mon Sep 17 00:00:00 2001 From: Diogo Castro Date: Mon, 3 Apr 2023 09:57:50 +0200 Subject: [PATCH] Denial and Resharing Default capability (#3762) --- changelog/unreleased/deny-default-reshare-capabilities.md | 3 +++ internal/http/services/owncloud/ocs/data/capabilities.go | 2 ++ .../owncloud/ocs/handlers/cloud/capabilities/capabilities.go | 2 ++ .../ocs/handlers/cloud/capabilities/capabilities_test.go | 4 ++-- 4 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 changelog/unreleased/deny-default-reshare-capabilities.md diff --git a/changelog/unreleased/deny-default-reshare-capabilities.md b/changelog/unreleased/deny-default-reshare-capabilities.md new file mode 100644 index 00000000000..3b274bc452a --- /dev/null +++ b/changelog/unreleased/deny-default-reshare-capabilities.md @@ -0,0 +1,3 @@ +Enhancement: Denial and Resharing Default capabilities + +https://github.com/cs3org/reva/pull/3762 \ No newline at end of file diff --git a/internal/http/services/owncloud/ocs/data/capabilities.go b/internal/http/services/owncloud/ocs/data/capabilities.go index 6199c091aca..ab0aaaa5ec9 100644 --- a/internal/http/services/owncloud/ocs/data/capabilities.go +++ b/internal/http/services/owncloud/ocs/data/capabilities.go @@ -149,6 +149,8 @@ type CapabilitiesDav struct { type CapabilitiesFilesSharing struct { APIEnabled ocsBool `json:"api_enabled" xml:"api_enabled" mapstructure:"api_enabled"` Resharing ocsBool `json:"resharing" xml:"resharing"` + ResharingDefault ocsBool `json:"resharing_default" xml:"resharing_default"` + DenyAccess ocsBool `json:"deny_access" xml:"deny_access"` GroupSharing ocsBool `json:"group_sharing" xml:"group_sharing" mapstructure:"group_sharing"` AutoAcceptShare ocsBool `json:"auto_accept_share" xml:"auto_accept_share" mapstructure:"auto_accept_share"` ShareWithGroupMembersOnly ocsBool `json:"share_with_group_members_only" xml:"share_with_group_members_only" mapstructure:"share_with_group_members_only"` diff --git a/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities.go b/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities.go index 480d5b26ba7..6221321e9cc 100644 --- a/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities.go +++ b/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities.go @@ -176,6 +176,8 @@ func (h *Handler) Init(c *config.Config) { // h.c.Capabilities.FilesSharing.User.SendMail is boolean // h.c.Capabilities.FilesSharing.Resharing is boolean + // h.c.Capabilities.FilesSharing.ResharingDefault is boolean + // h.c.Capabilities.FilesSharing.DenyAccess is boolean // h.c.Capabilities.FilesSharing.GroupSharing is boolean // h.c.Capabilities.FilesSharing.AutoAcceptShare is boolean // h.c.Capabilities.FilesSharing.ShareWithGroupMembersOnly is boolean diff --git a/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities_test.go b/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities_test.go index 5584287f4d3..09793af41a7 100644 --- a/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities_test.go +++ b/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities_test.go @@ -35,8 +35,8 @@ func TestMarshal(t *testing.T) { }, } - jsonExpect := `{"capabilities":{"core":null,"checksums":null,"files":null,"dav":null,"files_sharing":{"api_enabled":true,"resharing":false,"group_sharing":false,"auto_accept_share":false,"share_with_group_members_only":false,"share_with_membership_groups_only":false,"can_rename":false,"allow_custom":false,"search_min_length":0,"default_permissions":0,"user_enumeration":null,"federation":null,"public":null,"user":null},"group_based":null},"version":null}` - xmlExpect := `1000000000` + jsonExpect := `{"capabilities":{"core":null,"checksums":null,"files":null,"dav":null,"files_sharing":{"api_enabled":true,"resharing":false,"resharing_default":false,"deny_access":false,"group_sharing":false,"auto_accept_share":false,"share_with_group_members_only":false,"share_with_membership_groups_only":false,"can_rename":false,"allow_custom":false,"search_min_length":0,"default_permissions":0,"user_enumeration":null,"federation":null,"public":null,"user":null},"group_based":null},"version":null}` + xmlExpect := `100000000000` jsonData, err := json.Marshal(&cd) if err != nil {