Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent sub-slide behavior with nested bullet points #516

Closed
utdrmac opened this issue Apr 2, 2018 · 10 comments
Closed

Inconsistent sub-slide behavior with nested bullet points #516

utdrmac opened this issue Apr 2, 2018 · 10 comments

Comments

@utdrmac
Copy link

utdrmac commented Apr 2, 2018

Consider the following RemarkJS/Markdown:

---

* AAA

--
    * ...BBB
--
    * ...CCC

The above produces the desired effect: First show AAA, then "next slide" show BBB as a sub-bullet, then "next slide" show CCC at same sub-level as BBB.

But why does there have to be a blank link between * AAA and --?

Consider this:

* AAA
--
    * ...BBB
--
    * ...CCC

In the above, * ...BBB is appended to the previous point so it looks like * AAA*...BBB

Now consider this (line return between each bullet)

* AAA

--
    * ...BBB

--
    * ...CCC

In this, AAA shows fine. BBB shows fine. But when you navigate to slide 3, you see CCC but the spacing between AAA/BBB/CCC has completely changed. For some reason, in this case, <p>'s are added to each <li>. Why is that? This doesn't happen for just AAA and AAA/BBB. It only happens in case of 3+ subelements/subslides.

screen shot 2018-04-02 at 4 29 42 pm

screen shot 2018-04-02 at 4 30 19 pm

screen shot 2018-04-02 at 4 29 08 pm

screen shot 2018-04-02 at 4 30 11 pm

@utdrmac
Copy link
Author

utdrmac commented May 14, 2018

bump Hoping someone has a fix in the works for this. How do I start a bounty?

---

## Containers (LXC)

* OS-level virtualization method
--

* Allows running multiple, isolated systems, using a single kernel ("host")
--

* Kernel provides _cgroup_ functionality
    * CPU/memory/disk/network
    * No need for complete OS install
    * No device emulation/hypervisor
???
cgroup - control group (created by google, merged into 2.6.24, 2008)
--

* "Lightweight" virtual machine
--

* Local file system
--

* Accessible over network
--

* Container itself is isolated process
--

* "Baremetal" performance

@utdrmac
Copy link
Author

utdrmac commented May 14, 2018

screen shot 2018-05-14 at 3 38 24 pm

screen shot 2018-05-14 at 3 38 29 pm

@utdrmac
Copy link
Author

utdrmac commented Jun 25, 2018

@tripu Any discovery here? This is issue is highest priority for us @percona.

@utdrmac
Copy link
Author

utdrmac commented Jun 25, 2018

Here's another example where return inside blockquote creates issues similar to above:

---

## Run Sample Application

* On `app`, start the application and verify
    * Use another window for this or use `screen`
```sql
app# prepare_sysbench_oltp.sh

app# run_sysbench_oltp.sh
```
* Is replication flowing to all the nodes?
* Observe the sysbench transaction rate

screen shot 2018-06-25 at 4 08 15 pm

@mschilli87
Copy link
Contributor

@utdrmac

This is issue is highest priority for us @percona.

So where is your PR to fix it? 😉

@utdrmac
Copy link
Author

utdrmac commented Jun 26, 2018

@mschilli87 I'm not a programmer. I rely on the code creators to fix bugs.

@mschilli87
Copy link
Contributor

@utdrmac: I think 5 messages to > 200 people should be sufficient to point out a problem without offering a solution. The people working on this usually do so for free in their personal time after work. So I doubt that by 'bumping' this issue it is going to be solved sooner.

@utdrmac
Copy link
Author

utdrmac commented Jun 27, 2018

I spent the better part of today researching more into this. I discovered that having 4 space indentation produces an incorrect result though I'm not sure why. For whatever reason, the nested bullet point line is having an additional carriage return appended to the end. This appended line then gets sent to Marked for rendering. According to the Commonmark spec, the extra carriage return will create a "loose" list which adds the p tags. Ok, fine but why is an additional return being added in the first place? There's no difference between the above line: "foo" and "foo1" Why is foo1 being treated differently? I found 1 possibility which is a regex match against the beginning 4 spaces which matches CODE in lexer.js. I tried modifying this regex to match against 5 spaces, but that did not change anything.

4spaces
3spaces

@theseer
Copy link

theseer commented Oct 15, 2018

As far as I know, indentations have meaning in markdown.
So, when using 2 spaces for subpoints like this:

- Topic
  - Sub topic 1

The Sub topic 1 is recognized as a child bullet.
When adding -- with an empty line directly following:

- Topic
--

  - Sub Topic 1
--

  - Sub Topic 2

You should get the desired effect.

@abelards
Copy link
Collaborator

Looks fixed, so I'm closing it and documented it in the wiki
https://github.com/gnab/remark/wiki/HTML-CSS-JS-samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants