Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generating multi msg transaction with gnokey #845

Open
r3v4s opened this issue May 24, 2023 · 4 comments
Open

Support generating multi msg transaction with gnokey #845

r3v4s opened this issue May 24, 2023 · 4 comments
Assignees
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🌱 feature New update to Gno

Comments

@r3v4s
Copy link
Contributor

r3v4s commented May 24, 2023

Description

gno itself supports handling multi message transaction (for example, block 34248 has 1 transaction with 4 messages)
image

Based on default FULL SECURITY WITH AIRGAP guide, second step which generate unsigned.tx using gnokey maketx seems to be doesn't support multi message.

image

Of course, user can manually edit unsigned.tx with multiple messages and sign -> broadcast does work. But I think it should be better for UX if maketx support it directly.

@ajnavarro ajnavarro added 🌱 feature New update to Gno 📦 ⛰️ gno.land Issues or PRs gno.land package related labels May 30, 2023
@harry-hov
Copy link
Contributor

I didn't get the context in terms of UX. But since we already have the means to generate unsigned txs. I can think of 2 options here:

  • Option 1: We can simply append multiple txs to unsigned.tx. Something like

    gnokey maketx ... >> unsigned.tx
    gnokey maketx ... >> unsigned.tx
    gnokey maketx ... >> unsigned.tx

    And sign it

    gnokey sign unsigned.tx ... > signed.tx
  • Option 2: Support signing multiple tx files.

    gnokey sign unsigned1.tx unsigned2.tx unsigned3.tx ... > signed.tx

@r3v4s
Copy link
Contributor Author

r3v4s commented May 31, 2023

Terms I used for UX was.. it would be better if user can generate & sign multiple message transaction in one shot(single command)

Option 1 looks better for me

@harry-hov
Copy link
Contributor

What about supporting both options?

gnokey sign multiple-unsigned.tx unsigned1.tx unsigned2.tx ... > combined-signed.tx

@r3v4s
Copy link
Contributor Author

r3v4s commented Jun 1, 2023

What about supporting both options?

gnokey sign multiple-unsigned.tx unsigned1.tx unsigned2.tx ... > combined-signed.tx

Perfect, can't be better :D

Just let you know, I personally prefer Option 1 since it doesn't have to create bunch of unsigned1.tx, unsigned2.tx, ....

@moul moul moved this to 🔵 Not Needed for Launch in 🚀 The Launch [DEPRECATED] Sep 5, 2023
@moul moul added this to the 💡Someday/Maybe milestone Sep 6, 2023
@dongwon8247 dongwon8247 moved this to Blocked By / Issues / Questions in 🤝🏻 Partner: Onbloc Nov 12, 2023
@r3v4s r3v4s moved this from Blocked by / Wishlist / Issues to Backlog in 🤝🏻 Partner: Onbloc May 9, 2024
@r3v4s r3v4s moved this from History to Blocked by / Wishlist / Issues in 🤝🏻 Partner: Onbloc May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🌱 feature New update to Gno
Projects
Status: 🔵 Not Needed for Launch
Status: Backlog
Development

No branches or pull requests

4 participants