feat: auto-resign from open games when joining lobby (#123)

* feat: auto-resign from open games when joining lobby

* update workflow

* string -> error

* dont run perft tests normally

* fix test

.github/workflows/realm.yml

@@ -20,5 +20,5 @@ jobs:
       - uses: actions/setup-go@v4
         with:
           go-version: 'stable'
-      - run: go install github.com/gnolang/gno/gnovm/cmd/gno
-      - run: gno test --verbose ./realm
+      - run: go mod download -x
+      - run: go run github.com/gnolang/gno/gnovm/cmd/gno test -verbose -run 'Test([^P]|P[^e])' ./realm

.github/workflows/rules.yml

@@ -0,0 +1,22 @@
+name: rules
+
+on:
+  pull_request:
+    paths:
+      - "realm/rules.gno"
+  push:
+    branches:
+      - master
+      - main
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v4
+        with:
+          go-version: 'stable'
+      - run: go mod download -x
+      - run: go run github.com/gnolang/gno/gnovm/cmd/gno test -verbose -run 'TestPerft' ./realm

realm/chess.gno

@@ -513,7 +513,14 @@ func Resign(gameID string) string {
 	std.AssertOriginCall()
 
 	g := getGame(gameID, true)
+	err := resign(g)
+	if err != nil {
+		panic(err.Error())
+	}
+	return g.json()
+}
 
+func resign(g *Game) error {
 	caller := std.GetOrigCaller()
 	switch caller {
 	case g.Black:
@@ -523,12 +530,12 @@ func Resign(gameID string) string {
 		g.State = GameStateResigned
 		g.Winner = WinnerBlack
 	default:
-		panic("you are not involved in this game")
+		return errors.New("you are not involved in this game")
 	}
 	g.DrawOfferer = nil
 	g.saveResult()
 
-	return g.json()
+	return nil
 }
 
 // DrawOffer creates a draw offer in the current game, if one doesn't already

realm/lobby.gno

@@ -83,7 +83,16 @@ func LobbyJoin(seconds, increment int) {
 	// Ensure that user's previous games are finished (or timed out).
 	caller := std.GetOrigCaller()
 
-	assertGamesFinished(getUserGames(caller))
+	games := getUserGames(caller)
+	// XXX: temporary to avoid ever prohibiting a user from joining the lobby.
+	// when possible, change back to assertGamesFinished(games)
+	for _, g := range games {
+		if !g.State.IsFinished() {
+			if err := resign(g); err != nil {
+				panic("internal error (could not resign game " + g.ID + "): " + err.Error())
+			}
+		}
+	}
 	assertUserNotInLobby(caller)
 
 	// remove caller from lobbyPlayer2Game, so LobbyGameFound

realm/lobby_test.gno

@@ -165,7 +165,6 @@ func TestLobbyGameFound(t *testing.T) {
 
 func TestLobbyJoin_HasOpenGames(t *testing.T) {
 	cleanup()
-	std.TestSetOrigCaller(white)
 	g := &Game{
 		ID:    "123",
 		White: white,
@@ -176,12 +175,12 @@ func TestLobbyJoin_HasOpenGames(t *testing.T) {
 	addToUser2Games(white, g)
 	addToUser2Games(black, g)
 
-	defer func() {
-		e := recover()
-		if !strings.Contains(fmt.Sprint(e), "game 123 is not yet finished") {
-			t.Errorf("expecting 'game is not finished' panic, got %v", e)
-		}
-	}()
-
+	std.TestSetOrigCaller(white)
 	LobbyJoin(10*60, 5)
+	if g.State != GameStateResigned {
+		t.Errorf("state wrong: want %d got %d", GameStateResigned, g.State)
+	}
+	if g.Winner != WinnerBlack {
+		t.Errorf("winner wrong: want %q got %q", "black", g.Winner)
+	}
 }