fix: resolve signup form issues (#121)

* Add log

* Add logs, change errors

signup/functions/config/index.ts

@@ -8,30 +8,19 @@ export enum ApplicationEnv {
 }
 
 const {
-  NODE_PORT,
-  NODE_HOST,
-  NODE_ENV,
   REDIS_URL,
   MAILCHIMP_API_KEY,
   MAILCHIMP_API_SERVER,
   MAILCHIMP_AUDIENCE_ID,
   MAILCHIMP_JOURNEY_ID,
   MAILCHIMP_JOURNEY_STEP,
-  TOKEN_LIST
 } = process.env;
 
-const ENV: ApplicationEnv =
-  (NODE_ENV as ApplicationEnv) || ApplicationEnv.DEVELOPMENT;
-
 export const CONFIG = {
   REDIS_URL,
   MAILCHIMP_API_KEY,
   MAILCHIMP_API_SERVER,
   MAILCHIMP_AUDIENCE_ID,
   MAILCHIMP_JOURNEY_ID,
   MAILCHIMP_JOURNEY_STEP,
-  TOKEN_LIST,
-  NODE_PORT,
-  NODE_HOST,
-  NODE_ENV: ENV
 };

signup/functions/subscribe.ts

@@ -4,11 +4,22 @@ import mailchimp from '@mailchimp/mailchimp_marketing';
 import type { Handler, HandlerEvent } from '@netlify/functions';
 
 import { CONFIG } from './config';
-import { SubscribeRequest } from './types';
 import subscribeUserSchema from './schemas/users.schema';
 import { RedisClient } from './services/redis';
 import getRandomToken from './helpers/token.helper';
 
+interface SubscribeRequest {
+  firstName: string;
+  lastName: string;
+  email: string;
+  githubHandle: string;
+  socialHandle: string;
+  interests: string;
+  receiveNews: boolean;
+  participate: boolean;
+  termsAndConditions: boolean;
+}
+
 const ajv = new Ajv();
 ajvFormats(ajv);
 
@@ -26,22 +37,25 @@ export async function handler(event: HandlerEvent): Handler {
     // Validate the request
     const subscribeRequest: SubscribeRequest = JSON.parse(event.body);
 
+    // Intentional; TODO Remove
+    console.log(subscribeRequest);
+
     const isValid: boolean = ajv.validate(
       subscribeUserSchema,
       subscribeRequest
     );
     if (!isValid) {
       return {
         statusCode: 400,
-        body: JSON.stringify({ errors: 'Bad request' })
+        body: JSON.stringify({ errors: 'Unable to validate request' })
       };
     }
 
     // Make sure the ToC is accepted if the game is played
     if (subscribeRequest.termsAndConditions !== subscribeRequest.participate) {
       return {
         statusCode: 400,
-        body: JSON.stringify({ errors: { message: 'Bad request' } })
+        body: JSON.stringify({ errors: { message: 'Request is invalid' } })
       };
     }