Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add JSON output issues to a file #71

Merged
merged 8 commits into from
Sep 25, 2024

Conversation

0xtekgrinder
Copy link
Contributor

This PR adds a flag -json-output to get issues written as json inside a file with an example output being:

{"testdata/break/break1.gno":[{"Rule":"useless-break","Category":"","Message":"useless break statement at the end of case clause","Suggestion":"","Note":"","Snippet":"\t\tbreak","Confidence":0},{"Rule":"useless-break","Category":"","Message":"useless break statement at the end of case clause","Suggestion":"","Note":"","Snippet":"\t\tbreak","Confidence":0}]}

fixes #31

Copy link
Contributor

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributing to this crucial feature. Althought the current version runs very well, I have added a few suggestions here 👍

internal/types/types.go Outdated Show resolved Hide resolved
cmd/tlin/main.go Outdated Show resolved Hide resolved
@notJoon notJoon changed the title Add JSON output issues to a file feat: Add JSON output issues to a file Sep 24, 2024
Copy link
Contributor

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@notJoon notJoon merged commit 0775d8c into gnoverse:main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Output Option
2 participants