-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keybindings for version 2.0.1 in Fedora 32 does not work after upgrade from 1.92 #256
Comments
Can you run terminator on the commandline with |
The output is: ConfigBase::init: Borg::init: Preparing borg state for ConfigBase ** (terminator:45080): WARNING **: 13:34:21.705: Binding 'a' failed! |
From the above log, the logs displayed after using the keybinding Shift+Ctrl+T is: Window::on_key_press: Window::on_key_press: looked up 'new_tab' |
I have downgraded to the previous version and works fine the keybindings, when I upgrade again, stop working. |
Hmm, this is the code here that causes it
Can you do |
Thanks for helping me look into this, btw. |
This is the result: Just one comment, I have disabled in the configuration the "DBus server" option, I don't know if this has an impact |
In the configuration file for ibus? That could be the problem, lemme check |
This is the content of the config file:
|
Hmm, can you run the following in the python REPL and paste the output here?
Also, what version of python and psutil are you using? I'm just asking because I'm highly suspicious that #114 is what is causing this, but I can't reproduce it, and I can't figure out how it's happening. |
Could you please fix the last line? it seems to be incomplete or something does not work |
The default version of Python in my path is Python 3.8.6 and psutil 5.6.7 |
Updating your script to this
The output is: psutil.Process(pid=2235, name='ibus-daemon', started='13:56:12') |
I'm ... stumped. I can't figure out how to reproduce this. I'll take a stab at it in a little bit. There's some things I can think of doing |
@mattrose if you need me to test something, just let me know and I'll try |
Would you be comfortable running debug code from https://github.com/mattrose/terminator, if I push a branch to that? |
Yes, there is no problem, I can check out the branch, but I'll need you to provide me instructions to run it from the branch, I'm not very skilled with python |
Exactly same problem here - fedora32 as well, started with upgrade to terminator 2+. Running x11 (not wayland) if it helps. I speak python and will gladly help as this is extremely annoying :) $ ps auxw | grep ibus $ echo $XDG_SESSION_TYPE $ cat .config/terminator/config
$ terminator -d 2> terminator.log |
I'll see if I can create a branch with more debug statements in relevant spots tomorrow. I'll post here when it's complete. |
So, I did some more research on this, and this may fix it. The code that was swallowing your keystrokes was actually put in a long time ago in response to an ibus bug. Maybe this is a sign that they've fixed it. Can you do the following?
and try and reproduce the problem and see if it persists. whatever happens, please let me know, and we can either work on debugging further, or close this. (hopefully close this) |
I have tested it and worked fine, so the changes you made have fixed the issue, now the keybindings worked fine. |
Yay! Thanks so much for your patience and your work with me. |
just confirming - works for me as well, thank you! |
After I have upgraded from terminator-1.92-6.fc32.noarch to terminator-2.0.1-1.fc32.noarch, the keybindings stopped working. When using some of them like Shift+Ctrl+T to open a new tab, is displayed a red bulb, like it was signaling an error, but does not display any message. I have checked in the journalctl while performing the operations and I don't see any error.
The text was updated successfully, but these errors were encountered: