Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Allow to select the maximum slippage #952

Closed
anxolin opened this issue Apr 23, 2020 · 4 comments · Fixed by #1011
Closed

Allow to select the maximum slippage #952

anxolin opened this issue Apr 23, 2020 · 4 comments · Fixed by #1011
Assignees
Milestone

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 23, 2020

Consider making the price estimation more tight (don't subtract any value on top of the fees), and then offer these options:

image

0.5% would be the default option and pre-selected, so the price inputs it's already auto-filled with this value.

@koeppelmann, this percentages goes on top of the fees, right? because the actual price - 0.2% is the price that would make a solution feasible, so that would be the price at 0% (which we don't offer)

Let's see the proposal with an example:

  • An user wants to change 100 DAI for USDC
  • There's an order of 100 USDC for 100 DAI in the order book
  • The price estimation will return 99.8

The UI will offer:

  • 0.1% = 99.7002
  • 0.5% (default) = 99.301
  • 1% = 98.802

For the custom field, 0% would be a valid value, but also negative amounts, that would give you a better price, but the order won't probably be fulfilled soon.

cc/ @fleupold @alfetopito @c3rnst

@anxolin anxolin changed the title Allow to select the maximun slippage Allow to select the maximum slippage Apr 23, 2020
@W3stside
Copy link
Contributor

is this in the liquidity page or on all trade pages?

@W3stside W3stside self-assigned this Apr 29, 2020
@W3stside W3stside added this to the Sprint 14 milestone Apr 30, 2020
@W3stside
Copy link
Contributor

Est 3

@anxolin
Copy link
Contributor Author

anxolin commented May 14, 2020

is this in the liquidity page or on all trade pages?

I think we talked it in the chat. But for leaving it here too ---> Only trade page

@W3stside W3stside mentioned this issue May 14, 2020
3 tasks
@anxolin
Copy link
Contributor Author

anxolin commented May 20, 2020

@W3stside can we close by --> merge just the component and do not include it in the trade widget?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants