Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes when switching between two Safes #59

Open
samepant opened this issue Apr 7, 2022 · 0 comments
Open

App crashes when switching between two Safes #59

samepant opened this issue Apr 7, 2022 · 0 comments

Comments

@samepant
Copy link
Collaborator

samepant commented Apr 7, 2022

This is an edge case and requires the following:

  • two Safes with Exit Modules enabled, one with ERC-20 and one with ERC-721
  • An account that holds the corresponding ERC-20 and ERC-721 tokens of each Safe

to reproduce:

  1. go to Exit app, connect to ERC-20 Safe
  2. Connect wallet to Exit App
  3. Click on Safe address to change Safes, and connect to ERC-721 Safe
  4. app should crash with a BigNumber overflow (this line is causing it, the balance of the ERC-20 token in the connected wallet is still in state, rather than the ERC-721 balance)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant