Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make overallRequestLimit an option #2203

Closed
1 task done
fernsehmuell opened this issue Jun 11, 2024 · 4 comments · Fixed by #2209
Closed
1 task done

make overallRequestLimit an option #2203

fernsehmuell opened this issue Jun 11, 2024 · 4 comments · Fixed by #2209

Comments

@fernsehmuell
Copy link

fernsehmuell commented Jun 11, 2024

Welcome

  • Yes, I've searched similar issues on GitHub and didn't find any.

How do you use lego?

Binary

Detailed Description

Hello,
we use lego to get certificates from zerossl. I had to change the hardcoded const overallRequestLimit in certificate/authorization.go
I suggest making this an option for the cli. Something like --overallRequestLimit 6

Thanks!

@ldez ldez added the area/lib label Jun 11, 2024
@ldez
Copy link
Member

ldez commented Jun 11, 2024

hello,

can you explain why you need to change this value?

@fernsehmuell
Copy link
Author

fernsehmuell commented Jun 11, 2024

Hello ldez, because i ran into the rate limit of zerossl, which seems to be lower than the one of let's encrypt.

@ldez
Copy link
Member

ldez commented Jun 13, 2024

I'm trying to find the relevant ZeroSSL doc but I found nothing, it's annoying.

@ldez
Copy link
Member

ldez commented Jun 13, 2024

I found the doc:

https://help.zerossl.com/hc/en-us/articles/17864245480093-Advantages-over-Using-Let-s-Encrypt#h_01HT4Z1JCJFJQFJ1M3P7S085Q9

LE ZeroSSL
Overall Requests per second
Limit on the number of API requests per second for endpoints (e.g., new cert, revoke cert).
20 REST API - none
ACME - 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants