Run time panic when compiling with vgo

[Daniel-M]

Details

The same go-chi implementation shows errors at runtime related to the tool used to compile it. When compiled with go build the code snippet (below) runs as expected. When compiled with vgo build the binary throws a panic

Error

panic: chi: unsupported middleware signature: func(chi.Handler) chi.Handler

goroutine 1 [running]:
github.com/go-chi/chi.assertMiddleware(0x7bb3e0, 0x8628f8, 0x1, 0xc42022b720)

System details

• vgo: go version go1.10.2 linux/amd64 vgo:2018-02-20.1
• go: go version go1.10.2 linux/amd64 (manually installed)
• OS: Linux 4.16.0-2-amd64 Implement CloseNotify and Timeout middleware #1 SMP Debian 4.16.12-1 (2018-05-27) x86_64 GNU/Linux

Ways of reproduce the error

I have the following code snippet:

package main

import (
	"net/http"
	"github.com/go-chi/chi"
	"github.com/go-chi/chi/middleware"
)


func main() {
	r := chi.NewRouter()
	r.Use(middleware.Logger)
	r.Use(middleware.Recoverer)

	r.Get("/", func(w http.ResponseWriter, r *http.Request) {
		w.Write([]byte("root."))
	})

	http.ListenAndServe(":3333", r)
}

Compile with,

vgo build

Then run the binary and the panic above is thrown

Compile as,

go build

Then run the binary and the panic never happens

[Daniel-M]

Could it be that, somehow, vgo rewrites the middleware signature from the expected http.handler to the chi.Handler? the relevant portion of the code which throws the panic is,

(line 83 of github.com/go-chi/chi@v1.0.0/util.go)

// Runtime type checking of the middleware signature
func assertMiddleware(middleware interface{}) interface{} {
	switch t := middleware.(type) {
	default:
		panic(fmt.Sprintf("chi: unsupported middleware signature: %T", t))
	case func(http.Handler) http.Handler:
	case func(Handler) Handler:
	}
	return middleware
}

[VojtechVitek]

Your vgo is probably pulling chi v1.0.0 instead of latest v3.3.2. This is vgo problem.. See #327 and golang/go#25967

[Daniel-M]

@VojtechVitek Actually just found out this by myself and was about to close this issue

The solution was to change go.mod as:

require (
	github.com/go-chi/chi v2.0.0
	github.com/pressly/chi v2.0.0
        ...
)

[VojtechVitek]

note that v2.0.0 is old version that is not maintained anymore :)

[Daniel-M]

@VojtechVitek Oh, thanks, which version should I use then?

[Daniel-M]

The following worked for me

require (
    github.com/go-chi/chi v3.3.2
...`