From 13d6cd4e0d35ae7b880eb273d86c3a95f3e2ffa6 Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Mon, 6 Nov 2023 15:55:44 +0200 Subject: [PATCH] *: Correct spelling mistakes (#3555) --- CHANGELOG.md | 10 +++++----- Documentation/faq.md | 2 +- cmd/dlv/dlv_test.go | 2 +- pkg/proc/bininfo.go | 2 +- pkg/proc/fncall.go | 2 +- pkg/proc/internal/ebpf/bpf/trace.bpf.c | 2 +- pkg/proc/native/registers_darwin_amd64.go | 2 +- pkg/proc/proc_test.go | 2 +- pkg/proc/target_exec.go | 2 +- service/api/conversions.go | 2 +- service/api/types.go | 4 ++-- service/dap/server_test.go | 2 +- service/dap/types.go | 2 +- 13 files changed, 18 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4bacd2f5d6..a7874f03eb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,7 +48,7 @@ This project adheres to Semantic Versioning. - Fix starlark slice unmarshaling (@andreimatei) - Restore breakpoints set with line offsets on restart (@aarzilli) - Check recursion level when printing pointers (@aarzilli) -- Fix FrameDescriptionEntrie's append bug removing duplicates (@gocurr) +- Fix FrameDescriptionEntries' append bug removing duplicates (@gocurr) - Read context from sigtrampgo fixing cgo stack traces on 1.21 (@aarzilli) ### Changed @@ -301,7 +301,7 @@ This project adheres to Semantic Versioning. * DAP: Remote attach support (#2709, @polinasok) * DAP: Multi-client support (#2731, #2737, #2781, @polinasok) * DAP: Logpoints support (#2634, #2730, #2747, #2748, @suzmue) -* DAP: Dissasembly view support (#2713, #2716, #2728, #2742, @suzmue) +* DAP: Disassembly view support (#2713, #2716, #2728, #2742, @suzmue) * DAP: Support dlvCwd and use a temp file as default debug binary (#2660, #2734, @hyangah, @polinasok) * DAP: Auto-resume execution when setting breakpoints while running (#2726, @suzmue) * DAP: Add --client-addr flag to run dap with a predefined client (#2568, @hyangah) @@ -590,7 +590,7 @@ This project adheres to Semantic Versioning. ### Fixed - Fixed target program crash after step-instruction (#1738, @aarzilli) -- Fixed miscellaneus bugs related to debugging Position Indepentent Executables and plugins (#1775, @aarzilli) +- Fixed miscellaneus bugs related to debugging Position Independent Executables and plugins (#1775, @aarzilli) - Always remove breakpoints during detach (#1772, @hengwu0) - Fixed Delve's exit status after the program has ended (#1781, @derekparker) - Fixed nil pointer dereference in FunctionReturnLocations (#1789, @aarzilli) @@ -735,7 +735,7 @@ This project adheres to Semantic Versioning. - Fixed crashes when configuration file can not be created (@derekparker, @yuval-k, @aarzilli) - Fixed reported location of the go statement of goroutines (@derekparker) - Allow evaluation of constants specified without the full package path (@aarzilli) -- Fixed some integer arithmetics bugs in proc (@functionary) +- Fixed some integer arithmetic bugs in proc (@functionary) - Respect load configuration after reslicing a map (@aarzilli) - Fixed race condition between Halt and process death in the linux native backend (@aarzilli) - Support core files generated by gdb (@psanford) @@ -872,7 +872,7 @@ This project adheres to Semantic Versioning. ### Added -- Go 1.8 Compatability (@aarzilli) +- Go 1.8 Compatibility (@aarzilli) - Add Go 1.8 to test matrix (@derekparker) - Support NaN/Inf float values (@aarzilli) - Handle absence of stack barriers in Go 1.9 (@drchase) diff --git a/Documentation/faq.md b/Documentation/faq.md index 14e99be70b..8065ad48d9 100644 --- a/Documentation/faq.md +++ b/Documentation/faq.md @@ -116,7 +116,7 @@ The substitute-path feature can be used to solve this problem, see `help config` The `sources` command could also be useful in troubleshooting this problem, it shows the list of file paths that has been embedded by the compiler into the executable. -For more informations on path substitution see [path substitution](cli/substitutepath.md). +For more information on path substitution see [path substitution](cli/substitutepath.md). If you still think this is a bug in Delve and not a configuration problem, open an [issue](https://github.com/go-delve/delve/issues), filling the issue template and including the logs produced by delve with the options `--log --log-output=rpc,dap`. diff --git a/cmd/dlv/dlv_test.go b/cmd/dlv/dlv_test.go index 2fe55a9d0e..8333c33db7 100644 --- a/cmd/dlv/dlv_test.go +++ b/cmd/dlv/dlv_test.go @@ -947,7 +947,7 @@ func TestTrace2(t *testing.T) { func TestTraceMultipleGoroutines(t *testing.T) { dlvbin := getDlvBin(t) - // TODO(derekparker) this test has to be a bit vague to avoid flakyness. + // TODO(derekparker) this test has to be a bit vague to avoid flakiness. // I think a future improvement could be to use regexp captures to match the // goroutine IDs at function entry and exit. expected := []byte("main.callme(0, \"five\")\n") diff --git a/pkg/proc/bininfo.go b/pkg/proc/bininfo.go index 8d95cffd47..66f34e920f 100644 --- a/pkg/proc/bininfo.go +++ b/pkg/proc/bininfo.go @@ -2063,7 +2063,7 @@ func (bi *BinaryInfo) findTypeExpr(expr ast.Expr) (godwarf.Type, error) { } bi.expandPackagesInType(expr) if snode, ok := expr.(*ast.StarExpr); ok { - // Pointer types only appear in the dwarf informations when + // Pointer types only appear in the dwarf information when // a pointer to the type is used in the target program, here // we create a pointer type on the fly so that the user can // specify a pointer to any variable used in the target program diff --git a/pkg/proc/fncall.go b/pkg/proc/fncall.go index d256810422..541957e12e 100644 --- a/pkg/proc/fncall.go +++ b/pkg/proc/fncall.go @@ -87,7 +87,7 @@ type functionCallState struct { // called function panics. panicvar *Variable // undoInjection is set after evalop.CallInjectionSetTarget runs and cleared by evalCallInjectionComplete - // it contains informations on how to undo a function call injection without running it + // it contains information on how to undo a function call injection without running it undoInjection *undoInjection protocolReg uint64 diff --git a/pkg/proc/internal/ebpf/bpf/trace.bpf.c b/pkg/proc/internal/ebpf/bpf/trace.bpf.c index e51aa5a611..da5e43217e 100644 --- a/pkg/proc/internal/ebpf/bpf/trace.bpf.c +++ b/pkg/proc/internal/ebpf/bpf/trace.bpf.c @@ -157,7 +157,7 @@ int get_goroutine_id(function_parameter_list_t *parsed_args) { __always_inline void parse_params(struct pt_regs *ctx, unsigned int n_params, function_parameter_t params[6]) { - // Since we cannot loop in eBPF programs let's take adavantage of the + // Since we cannot loop in eBPF programs let's take advantage of the // fact that in C switch cases will pass through automatically. switch (n_params) { case 6: diff --git a/pkg/proc/native/registers_darwin_amd64.go b/pkg/proc/native/registers_darwin_amd64.go index fb312ce4c0..4d00c3d7e6 100644 --- a/pkg/proc/native/registers_darwin_amd64.go +++ b/pkg/proc/native/registers_darwin_amd64.go @@ -298,7 +298,7 @@ func registers(thread *nativeThread) (proc.Registers, error) { } kret = C.get_identity(C.mach_port_name_t(thread.os.threadAct), &identity) if kret != C.KERN_SUCCESS { - return nil, fmt.Errorf("could not get thread identity informations") + return nil, fmt.Errorf("could not get thread identity information") } /* thread_identifier_info::thread_handle contains the base of the diff --git a/pkg/proc/proc_test.go b/pkg/proc/proc_test.go index 240f280a09..0846ab7131 100644 --- a/pkg/proc/proc_test.go +++ b/pkg/proc/proc_test.go @@ -5066,7 +5066,7 @@ func TestRefreshCurThreadSelGAfterContinueOnceError(t *testing.T) { f, l, fn := p.BinInfo().PCToLine(pc) t.Logf("Second continue did not return an error %s:%d %#v", f, l, fn) if fn != nil && fn.Name == "runtime.fatalpanic" { - // this is also ok, it just means this debugserver supports --unmask-signals and it's working as intented. + // this is also ok, it just means this debugserver supports --unmask-signals and it's working as intended. return } } diff --git a/pkg/proc/target_exec.go b/pkg/proc/target_exec.go index 77edae83b2..282167d273 100644 --- a/pkg/proc/target_exec.go +++ b/pkg/proc/target_exec.go @@ -478,7 +478,7 @@ func frameoffCondition(frame *Stackframe) ast.Expr { } // StepOut resumes the processes in the group, continuing the selected target -// until until the current goroutine exits the function currently being +// until the current goroutine exits the function currently being // executed or a deferred function is executed func (grp *TargetGroup) StepOut() error { backward := grp.GetDirection() == Backward diff --git a/service/api/conversions.go b/service/api/conversions.go index f64bd3fbee..e44c4020ca 100644 --- a/service/api/conversions.go +++ b/service/api/conversions.go @@ -53,7 +53,7 @@ func ConvertLogicalBreakpoint(lbp *proc.LogicalBreakpoint) *Breakpoint { return b } -// ConvertPhysicalBreakpoints adds informations from physical breakpoints to an API breakpoint. +// ConvertPhysicalBreakpoints adds information from physical breakpoints to an API breakpoint. func ConvertPhysicalBreakpoints(b *Breakpoint, lbp *proc.LogicalBreakpoint, pids []int, bps []*proc.Breakpoint) { if len(bps) == 0 { if lbp != nil { diff --git a/service/api/types.go b/service/api/types.go index 6e893a5327..6ce420dca6 100644 --- a/service/api/types.go +++ b/service/api/types.go @@ -179,7 +179,7 @@ type Thread struct { // Breakpoint this thread is stopped at Breakpoint *Breakpoint `json:"breakPoint,omitempty"` - // Informations requested by the current breakpoint + // Information requested by the current breakpoint BreakpointInfo *BreakpointInfo `json:"breakPointInfo,omitempty"` // ReturnValues contains the return values of the function we just stepped out of @@ -422,7 +422,7 @@ type DebuggerCommand struct { UnsafeCall bool `json:"unsafeCall,omitempty"` } -// BreakpointInfo contains informations about the current breakpoint +// BreakpointInfo contains information about the current breakpoint type BreakpointInfo struct { Stacktrace []Stackframe `json:"stacktrace,omitempty"` Goroutine *Goroutine `json:"goroutine,omitempty"` diff --git a/service/dap/server_test.go b/service/dap/server_test.go index 34144826c8..611ddde2e5 100644 --- a/service/dap/server_test.go +++ b/service/dap/server_test.go @@ -3530,7 +3530,7 @@ func TestConcurrentBreakpointsLogPoints(t *testing.T) { client.ExpectConfigurationDoneResponse(t) // There may be up to 1 breakpoint and any number of log points that are - // hit concurrently. We should get a stopped event everytime the breakpoint + // hit concurrently. We should get a stopped event every time the breakpoint // is hit and an output event for each log point hit. var oeCount, seCount int for oeCount < 10 || seCount < 10 { diff --git a/service/dap/types.go b/service/dap/types.go index aee2357360..812dd1a4a4 100644 --- a/service/dap/types.go +++ b/service/dap/types.go @@ -105,7 +105,7 @@ type LaunchConfig struct { // It should be a string like `dlv --build-flags`, or // an array of strings that is augmented when invoking the go build or // test command through os/exec.Command API. - // For example, both forms are acceptible. + // For example, both forms are acceptable. // "buildFlags": "-tags=integration -ldflags='-X main.Hello=World'" // or // "buildFlags": ["-tags=integration", "-ldflags=-X main.Hello=World"]