make with -jX fails on bindata tasks

[ghost]

• Gitea version (or commit ref): v1.1.0
• Git version: 2.11.0
• Operating system: Debian 9
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
  • Not relevant
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Log:

› TAGS="bindata" make generate build -j8                                                                                                                                     Sonntag, 12. Mär. 2017 - 23:17:57 CET
go generate code.gitea.io/gitea code.gitea.io/gitea/cmd code.gitea.io/gitea/integrations/internal/utils code.gitea.io/gitea/models code.gitea.io/gitea/models/migrations code.gitea.io/gitea/modules/auth code.gitea.io/gitea/modules/auth/ldap code.gitea.io/gitea/modules/auth/oauth2 code.gitea.io/gitea/modules/auth/pam code.gitea.io/gitea/modules/avatar code.gitea.io/gitea/modules/base code.gitea.io/gitea/modules/context code.gitea.io/gitea/modules/cron code.gitea.io/gitea/modules/highlight code.gitea.io/gitea/modules/httplib code.gitea.io/gitea/modules/indexer code.gitea.io/gitea/modules/lfs code.gitea.io/gitea/modules/log code.gitea.io/gitea/modules/mailer code.gitea.io/gitea/modules/markdown code.gitea.io/gitea/modules/minwinsvc code.gitea.io/gitea/modules/notification code.gitea.io/gitea/modules/options code.gitea.io/gitea/modules/process code.gitea.io/gitea/modules/public code.gitea.io/gitea/modules/setting code.gitea.io/gitea/modules/ssh code.gitea.io/gitea/modules/sync code.gitea.io/gitea/modules/templates code.gitea.io/gitea/modules/user code.gitea.io/gitea/modules/util code.gitea.io/gitea/routers code.gitea.io/gitea/routers/admin code.gitea.io/gitea/routers/api/v1 code.gitea.io/gitea/routers/api/v1/admin code.gitea.io/gitea/routers/api/v1/convert code.gitea.io/gitea/routers/api/v1/misc code.gitea.io/gitea/routers/api/v1/org code.gitea.io/gitea/routers/api/v1/repo code.gitea.io/gitea/routers/api/v1/user code.gitea.io/gitea/routers/api/v1/utils code.gitea.io/gitea/routers/dev code.gitea.io/gitea/routers/org code.gitea.io/gitea/routers/repo code.gitea.io/gitea/routers/user
go build -i -v -tags 'bindata' -ldflags '-s -w -X "main.Version=1.1.0+6-gb064ae0c" -X "main.Tags=bindata"' -o gitea
code.gitea.io/gitea/modules/options
code.gitea.io/gitea/modules/public
bindata.go
# code.gitea.io/gitea/modules/public
modules/public/bindata.go:21233: string not terminated
modules/public/bindata.go:21233: syntax error: unexpected semicolon or newline, expecting comma or )
code.gitea.io/gitea/models
code.gitea.io/gitea/modules/auth
code.gitea.io/gitea/modules/cron
code.gitea.io/gitea/modules/templates
code.gitea.io/gitea/modules/indexer
code.gitea.io/gitea/modules/ssh
code.gitea.io/gitea/modules/notification
code.gitea.io/gitea/routers/api/v1/convert
bindata.go
code.gitea.io/gitea/modules/context
bindata.go
code.gitea.io/gitea/routers/api/v1/utils
code.gitea.io/gitea/modules/lfs
code.gitea.io/gitea/routers/api/v1/misc
code.gitea.io/gitea/routers/dev
code.gitea.io/gitea/routers/repo
code.gitea.io/gitea/routers/user
code.gitea.io/gitea/routers/api/v1/repo
code.gitea.io/gitea/routers/api/v1/user
code.gitea.io/gitea/routers
code.gitea.io/gitea/routers/org
code.gitea.io/gitea/routers/api/v1/admin
code.gitea.io/gitea/routers/api/v1/org
code.gitea.io/gitea/routers/admin
code.gitea.io/gitea/routers/api/v1
Makefile:96: die Regel für Ziel „gitea“ scheiterte
make: *** [gitea] Fehler 2

Description

If I want to use -jX to use all my cores, make tasks with bindata are not working. There might be a problem with multicore support.

(TAGS="bindata" make generate build works fine)

[pgaskin]

It will not work because the recipes cannot be run in parallel (as far as I know).

[ghost]

@geek1011 It seems that you are right but in my opinion it might be a good idea to provide parallel tasks support. As far as I know the compilation time itself will benefit from multiple cores.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.