Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/comment edit history #12886

Closed
lunny opened this issue Sep 18, 2020 · 6 comments · Fixed by #16909
Closed

Issue/comment edit history #12886

lunny opened this issue Sep 18, 2020 · 6 comments · Fixed by #16909
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@lunny
Copy link
Member

lunny commented Sep 18, 2020

图片

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Sep 18, 2020
@delvh
Copy link
Member

delvh commented Aug 31, 2021

I am conflicted about this feature:
I can totally see its value regarding data integrity and traceability.
However, I noticed that I also find it refreshing that Gitea does not track the edit history as small typos can then be deleted without a trace.

@redstonedesigner
Copy link
Contributor

Perhaps as a compromise, there could be a set amount of time where an edit wouldn't be logged (configurable by an administrator) to allow for typographical errors to be caught and corrected.
After that, the edits would be logged as depicted above.

Just my opinion.

@delvh
Copy link
Member

delvh commented Sep 1, 2021

That sounds to me like a really good compromise.
I would suggest a timespan of 15-30 minutes as default.
(If you read through the edit history of this message, you can also already see why I think that this is a good compromise 😉 )

@lunny
Copy link
Member Author

lunny commented Sep 2, 2021

That sounds to me like a really good compromise.
I would suggest a timespan of 15-30 minutes as default.
(If you read through the edit history of this message, you can also already see why I think that this is a good compromise 😉 )

Or the time is configuable.

@delvh
Copy link
Member

delvh commented Sep 2, 2021

Yes, but I meant as fallback if no time has been specified inside the app.ini.

I would definitely say that this should only be a server-wide setting with no further extensibility because otherwise you can have repositories where you cannot assume the validity of comments which would make this feature in my opinion less useful.

@wxiaoguang
Copy link
Contributor

But do we really need to make it complex? GitHub just saved every change.

@lafriks lafriks added this to the 1.16.0 milestone Oct 11, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants