Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] /repos/{owner}/{repo}/issues/{id}/times only lists times of the user which is calling the API #13414

Closed
1 task done
samurous opened this issue Nov 3, 2020 · 2 comments · Fixed by #14081
Closed
1 task done
Labels
modifies/api This PR adds API routes or modifies them

Comments

@samurous
Copy link

samurous commented Nov 3, 2020

  • Gitea version (or commit ref): 1.12.3
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)

Description

If the user is not an Admin of the repo, the API call will return only times added by the user calling the API.
But when accessing the front-end, the user can view all tracked times.

Example

@6543 6543 added the modifies/api This PR adds API routes or modifies them label Nov 19, 2020
@noerw
Copy link
Member

noerw commented Dec 21, 2020

This limitation exists for privacy reasons:
Listing times on the UI is one thing, making them publicily available via API and thus large scale scrapable (across repos with a single request) a whole different thing.

#14081 will lower the requirement to access other users' times to issue managers, so I hope that helps.

@samurous
Copy link
Author

Hmm, I don't think an attacker would be stopped by adding a barrier of web scraping. But reducing the access requirement to issue managers does help indeed, thank you!

@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
modifies/api This PR adds API routes or modifies them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants