Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support S3 non-pathstyle (V2) #14991

Closed
OrvilleQ opened this issue Mar 14, 2021 · 2 comments · Fixed by #30969
Closed

Support S3 non-pathstyle (V2) #14991

OrvilleQ opened this issue Mar 14, 2021 · 2 comments · Fixed by #30969
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@OrvilleQ
Copy link

Currently Gitea's S3 support only support path style which MinIO could handle with. But a lot of S3 provider out there do not support path style like AWS S3.

Amazon S3 currently supports two request URI styles in all regions: path-style (also known as V1) that includes bucket name in the path of the URI (example: //s3.amazonaws.com//key), and virtual-hosted style (also known as V2) which uses the bucket name as part of the domain name (example: //.s3.amazonaws.com/key).
Customers should update their applications to use the virtual-hosted style request format when making S3 API requests before September 30th, 2020 to avoid any service disruptions. Customers using the AWS SDK can upgrade to the most recent version of the SDK to ensure their applications are using the virtual-hosted style request format.

So please support non-pathtyle.

@OrvilleQ
Copy link
Author

OrvilleQ commented Mar 14, 2021

And also, S3 is a Object Storage standard created by Amazon and been widely used by other storage providers. I don't think named gitea's S3 storage support to MINIO, one of countless programs that support this standard, is a good move. It might be confusing, in especially if someone add other network storage solution to gitea like Swift or B2.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Mar 14, 2021
@lunny
Copy link
Member

lunny commented Mar 14, 2021

According minio golang sdk, https://docs.min.io/docs/golang-client-quickstart-guide.html

The MinIO Go Client SDK provides simple APIs to access any Amazon S3 compatible object storage.

And more Storage implementation PRs are welcome. See https://github.com/go-gitea/gitea/blob/master/modules/storage/storage.go#L66

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants