[Bug] Delete Repo Fails On Windows

[kdumontnu]

• Gitea version (or commit ref): 1.15.0+dev-285-g6a8e5f69c
• Git version:
• Operating system: Windows
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
• Log gist:

2021/05/13 13:45:45 models/admin.go:87:removeAllWithNotice() [W] Delete repository files [C:\Users\<user>\Documents\5 - Software Development\gitea\data\gitea-repositories\test\lfs_demo.git]: remove C:\Users\<user>\Documents\5 - Software Development\gitea\data\gitea-repositories\test\lfs_demo.git: The process cannot access the file because it is being used by another process.
2021/05/13 13:45:45 ...s/context/context.go:692:1() [D] Session ID: 7b2e3c9790a33b69

Description

Gitea cannot seem to delete a repo on Windows. The contents of the directory are removed, but the .git repo directory root is left behind. This results in a collision if you try to create another repo with the same name.

Appears to work fine on v1.14.

Screenshots

Says the repository was successfully deleted.

Collision when creating a repo with the same name

[zeripath]

it'll be due to the open git repo.