[FEATURE] Refresh button when branch changes

[kdumontnu]

Feature Description

Sometimes when reviewing large PRs, reviewers can be reviewing stale data if the branch has been updated since last loading the page. GitHub has a nice little feature that pops up an orange "refresh" button if the underlying branch changes. It would be great if Gitea had something similar.

From zeripath: "there are a couple of things that could be used for this. Probably the best thing to do would be for the webpage to register with the eventsource and get that to listen for the notify"

Screenshots

[silverwind]

Yes, eventsource can be used in theory for server-to-client updates. I have the general impression that our eventsource is rather unstable and I think in the long run, we'd be better to switch it to websockets.

[lunny]

Yes, switching to websocket is a final way we need to do.

[zeripath]

Honestly when I wrote the eventsource I looked at all of the alternatives and thought that as we only needed server side events a websocket was not the way to go.

[zeripath]

Yes, eventsource can be used in theory for server-to-client updates. I have the general impression that our eventsource is rather unstable and I think in the long run, we'd be better to switch it to websockets.

What evidence do you have that the eventsource is unstable?

[kdumontnu]

Can this not be completed as easily using the eventsource? Or is the idea that we don't want to keep adding to it?

[anbraten]

Eventsource works basically fine. Its heavily being used for similar usecases in some projects like woodpecker. But the most sustainable solution would probably be following the graphql (#14721) idea. Adding eventsources / own websocket protocols for such large projects like gitea don't scale in my opinion. If you are really searching for a quick and dirty solution, I would rather suggest to use some kind of polling with setTimeout / setInterval every 3 seconds as those api endpoints already exists.

[lunny]

An uniform websocket service could be used in many pages/features. Gitea should move forward to be more instantly in code review or other collabrations.
i.e. We need to update the new comments when we stay in the issue page, need to see the review comment update and the refresh button on code review page.
EventSource will need server-side long pull technical which belongs to HTTP 1.1. By Websocket, we could send and receive multiple types messages in one page. And because of Golang's high performance, over 1M connection could also be possible.

[more-pepsi]

Any progress on this? Would love to add lazy loading of large pull requests as-well. Happy to pull or do some little tasks for ya'll

[kdumontnu]

Any progress on this? Would love to add lazy loading of large pull requests as-well. Happy to pull or do some little tasks for ya'll

I have not heard of any progress yet. I think it's probably important to point out that these three things are separate issues:

• Refresh Page notice (this PR) - existing eventsource implementation is fine
• Lazy Load diffs (much improved with (Allow Loading of Diffs that are too large #17739 Add buttons to allow loading of incomplete diffs #16829, but also see Browser crashes on accessing big files #12141)
• Eventsource -> websocket (new issue?)

[maxbol]

I'm up for solving this if the bounty still stands and noone else is working on it?

[more-pepsi]

Sse seems fine imo

https://stackoverflow.com/questions/5195452/websockets-vs-server-sent-events-eventsource

[maxbol]

Recommended reading if you decide on going the GraphQL route: https://wundergraph.com/blog/deprecate_graphql_subscriptions_over_websockets

And:
https://www.the-guild.dev/blog/subscriptions-and-live-queries-real-time-with-graphql

[MarwaNoorullahKhan1]

why does my github not have refresh button