Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch filtering inconsistency #19778

Closed
acopxl opened this issue May 21, 2022 · 4 comments · Fixed by #19885
Closed

branch filtering inconsistency #19778

acopxl opened this issue May 21, 2022 · 4 comments · Fixed by #19885
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.16.9

Comments

@acopxl
Copy link

acopxl commented May 21, 2022

Description

Branch filtering works differently on different screens. It seems to be working fine on the "Code" page. On "New Pull Request" show branches that seem not to match the string we enter

Screenshots

Screenshot from 2022-05-21 21-26-56
Screenshot from 2022-05-21 21-27-11

Gitea Version

1.16.7

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Chrome
@acopxl acopxl added type/bug topic/ui Change the appearance of the Gitea UI labels May 21, 2022
@wxiaoguang
Copy link
Contributor

It's caused by Dropdown's full-search behavior.

fomantic/Fomantic-UI#1737

gitea/web_src/js/features/repo-common.js

Lines 110 to 115 in e31c616

export function initRepoCommonFilterSearchDropdown(selector) {
const $dropdown = $(selector);
$dropdown.dropdown({
fullTextSearch: true,
selectOnKeydown: false,
onChange(_text, _value, $choice) {

Maybe it can be fixed by the suggestion of the discussion : fullTextSearch: 'exact'

@wxiaoguang wxiaoguang added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 31, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone May 31, 2022
@zeripath
Copy link
Contributor

zeripath commented Jun 4, 2022

Yup exact would stop this fuzzy searching behaviour

@lunny
Copy link
Member

lunny commented Jun 4, 2022

It's caused by Dropdown's full-search behavior.

fomantic/Fomantic-UI#1737

gitea/web_src/js/features/repo-common.js

Lines 110 to 115 in e31c616

export function initRepoCommonFilterSearchDropdown(selector) {
const $dropdown = $(selector);
$dropdown.dropdown({
fullTextSearch: true,
selectOnKeydown: false,
onChange(_text, _value, $choice) {

Maybe it can be fixed by the suggestion of the discussion : fullTextSearch: 'exact'

Do you have plan to send a PR?

@wxiaoguang wxiaoguang mentioned this issue Jun 4, 2022
Merged
@wxiaoguang
Copy link
Contributor

Use exact search instead of fuzzy search for branch filter dropdown #19885

@lunny lunny modified the milestones: 1.17.0, 1.16.9 Jun 4, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.16.9
Development

Successfully merging a pull request may close this issue.

Use exact search instead of fuzzy search for branch filter dropdown wxiaoguang/gitea
4 participants
@lunny @zeripath @wxiaoguang @acopxl