-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heatmap data needs to be optimized #21045
Comments
Does #23574 resolve this partially? |
No that is unrelated. The problem with heatmap data, IIRC is both that the backend database query is expensive (primary issue), and that the JSON format that is dumped into the HTML is inefficient. |
Since it's by day, maybe we can store the result in some table. |
Some form of cache would be needed I guess. Note that users can push commits for previous or even future dates, so it would have to be invalidated on every user push. |
We do not show commits in heatmap but only user actions so they can be only with current date not in the past or future. Previously when I implemented it it was returning data already summed up by day but it was reworked later on to return all data to fronted to account user timezone |
Data format is currently [{"timestamp":1657821600,"contributions":1}] It could at least be minified to [[1657821600,1]] Still I think real performance increase can only come from some form of caching. |
Duplicate of #29769 since more discussion there. |
A regular page load is about 30-40ms rendering time but any page containing heatmap data like the homepage, drastically increases page rendering time to around 200-400ms. We should find ways to optimize this.
The text was updated successfully, but these errors were encountered: