Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show Add file button if user has no rights to add files to repo #21179

Closed
lafriks opened this issue Sep 15, 2022 · 2 comments
Closed

Do not show Add file button if user has no rights to add files to repo #21179

lafriks opened this issue Sep 15, 2022 · 2 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.17.4

Comments

@lafriks
Copy link
Member

lafriks commented Sep 15, 2022 •
edited
Loading

Description

Currently button with empty submenu is shown

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Not relevant

Database

No response
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI type/bug labels Sep 15, 2022
@lunny lunny added this to the 1.17.3 milestone Sep 16, 2022
@wolfogre
Copy link
Member

I believe it has been fixed by #20718, and backport #20719 has been merged too.

I can't reproduce the error on v1.17.2, maybe this is a false positive?

@6543 6543 modified the milestones: 1.17.3, 1.17.4 Oct 13, 2022
@wolfogre wolfogre added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Nov 8, 2022
@lunny
Copy link
Member

lunny commented Dec 12, 2022

I can confirm this has been fixed in branch v1.17.

@lunny lunny closed this as completed Dec 12, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.17.4
Development

No branches or pull requests
4 participants
@lunny @lafriks @wolfogre @6543