Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Add 'show timestamp', 'show fullscreen' and 'delete logs' features to job detail page #24728

Open
HesterG opened this issue May 15, 2023 · 1 comment
Open

[Proposal] Add 'show timestamp', 'show fullscreen' and 'delete logs' features to job detail page #24728

HesterG opened this issue May 15, 2023 · 1 comment
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first. type/summary This issue aggregates a bunch of other issues

Comments

@HesterG
Copy link
Contributor

HesterG commented May 15, 2023 •
edited
Loading

Feature Description

The former two should be frontend features and timestamp is already passed from backend. But for "delete logs", might need to implement backend as well.

Show timestamp:

Screen Shot 2023-05-15 at 16 06 20

Show fullscreen:
Screen Shot 2023-05-15 at 16 06 33

Delete logs:

Screen Shot 2023-05-15 at 16 06 53

Screenshots

No response
@HesterG HesterG added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/summary This issue aggregates a bunch of other issues labels May 15, 2023
@lunny lunny added topic/ui Change the appearance of the Gitea UI and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels May 15, 2023
@yardenshoham yardenshoham added the proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. label May 15, 2023
@HesterG HesterG mentioned this issue May 23, 2023
Merged
@HesterG
Copy link
Contributor Author

HesterG commented May 23, 2023

Also good to have following format of time display as an option

Screen Shot 2023-05-23 at 18 19 59

silverwind added a commit that referenced this issue May 30, 2023
@HesterG @silverwind @wxiaoguang
Add show timestamp/seconds and fullscreen options to action page (#24876
1ea5c8b 
)

Part of #24728

- The timestamp shows local time and is parsed by `date.toLocaleString`;
- "show seconds" and "show timestamps" are mutually exclusive, and they
can be both hidden.


https://github.com/go-gitea/gitea/assets/17645053/89531e54-37b7-4400-a6a0-bb3cc69eb6f5

Update for timestamp format:

<img width="306" alt="Screen Shot 2023-05-25 at 09 07 47"
src="https://github.com/go-gitea/gitea/assets/17645053/2d99768d-d39c-4c9e-81a2-7bc7470399dd">

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first. type/summary This issue aggregates a bunch of other issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @HesterG @yardenshoham