Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign reviewers on pull request creation #26289

Closed
splitt3r opened this issue Aug 2, 2023 · 9 comments · Fixed by #32403
Closed

Assign reviewers on pull request creation #26289

splitt3r opened this issue Aug 2, 2023 · 9 comments · Fixed by #32403
Labels
good first issue Likely to be an easy fix proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.23.0

Comments

@splitt3r
Copy link
Contributor

splitt3r commented Aug 2, 2023 •
edited
Loading

Feature Description

The pull request creation dialog currently misses the reviewers slection. You can only select an assinngee while creating a pull request. After creating the pull request and opening it you can select the reviewer for it. GitHub allows you to assign the pull request diretly to a reviewer while creating it which is pretty neat. It makes the workflow of suggesting changes for a repo more convenient.

Screenshots

GitHub:
GitHub

Gitea:
Gitea
@splitt3r splitt3r added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Aug 2, 2023
@a1012112796 a1012112796 added the good first issue Likely to be an easy fix label Aug 3, 2023
@puni9869 puni9869 added the proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. label Aug 3, 2023
@splitt3r
Copy link
Contributor Author

I'll try to implement the fix for this myself and create a PR for it.

@splitt3r splitt3r mentioned this issue Aug 19, 2023
Closed
@jpraet jpraet mentioned this issue Dec 29, 2023
Closed
@lunny
Copy link
Member

lunny commented Dec 30, 2023 •
edited
Loading

duplicated with #13905 That one is for API

@lunny lunny closed this as completed Dec 30, 2023
@lunny lunny reopened this Dec 30, 2023
@joshuanazareth97
Copy link

Hi, I'd like to contribute. Is this issue open to PRs?

@delvh
Copy link
Member

delvh commented Apr 1, 2024

Sure. All issues are open for PRs.

@lunny
Copy link
Member

lunny commented Apr 2, 2024

If the pull request creator indicated the reviewers, the codeowner reviewers should be ignored.

@splitt3r
Copy link
Contributor Author

splitt3r commented Apr 2, 2024

Hi, I'd like to contribute. Is this issue open to PRs?

You can use the existing PR as a starting point. Thanks for picking this up 👍🏻

@CalK16
Copy link
Contributor

CalK16 commented Sep 26, 2024

Hi, I'd like to make my contribution to this issue. Is it still open to PRs?

@splitt3r
Copy link
Contributor Author

Hi, I'd like to make my contribution to this issue. Is it still open to PRs?

Since my pr is abadoned and i don't have the time to work on it anymore it would be great if you could fix the issue.

@lunny
Copy link
Member

lunny commented Sep 27, 2024

Hi, I'd like to make my contribution to this issue. Is it still open to PRs?

Since my pr is abadoned and i don't have the time to work on it anymore it would be great if you could fix the issue.

It was almost completed for me when I last reviewed it.

图片

@wxiaoguang wxiaoguang linked a pull request Nov 9, 2024 that will close this issue
Add reviewers selection to new pull request fixes #26289 #32403
Merged
@lunny lunny added this to the 1.23.0 milestone Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Likely to be an easy fix proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.23.0
7 participants
@lunny @splitt3r @a1012112796 @joshuanazareth97 @delvh @CalK16 @puni9869