Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate check and an auto disappear timer for toast #26651

Closed
yp05327 opened this issue Aug 22, 2023 · 4 comments · Fixed by #31501
Closed

Duplicate check and an auto disappear timer for toast #26651

yp05327 opened this issue Aug 22, 2023 · 4 comments · Fixed by #31501
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.23.0

Comments

@yp05327
Copy link
Contributor

yp05327 commented Aug 22, 2023 •
edited
Loading

Description

Thanks for @wxiaoguang's work in #26535
But we need do some more works for toast:
image

How to reproduce?
just click rerun job button crazily :)

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@yp05327
Copy link
Contributor Author

yp05327 commented Nov 15, 2023

gitea/web_src/js/modules/toast.js

Lines 11 to 19 in f65977d

warning: {
icon: 'gitea-exclamation',
background: 'var(--color-orange)',
duration: -1, // requires dismissal to hide
},
error: {
icon: 'gitea-exclamation',
background: 'var(--color-red)',
duration: -1, // requires dismissal to hide

duration is -1, so it will not disappear until user close it . 😕

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 22, 2024

Is it possible to check the content of the warning message, and if they are same then add (number) at the behind of the existing one?

@lunny
Copy link
Member

lunny commented Mar 22, 2024

Fixed by #28873 ?

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 22, 2024 •
edited
Loading

Fixed by #28873 ?

No, it fix JS error, this is triggered by http response.
ps: tested in the latest commit.

@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label Apr 24, 2024
@yp05327 yp05327 mentioned this issue Jun 27, 2024
Merged
wxiaoguang added a commit that referenced this issue Jun 27, 2024
@wxiaoguang @silverwind
Make toast support preventDuplicates (#31501)
c1fe6fb 
make preventDuplicates default to true, users get a clear UI feedback
and know that "a new message appears".

Fixes: #26651

---------

Co-authored-by: silverwind <me@silverwind.io>
@yp05327 yp05327 added this to the 1.23.0 milestone Jun 28, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging a pull request may close this issue.

Make toast support preventDuplicates wxiaoguang/gitea
2 participants
@lunny @yp05327