Gitea OAuth2 based SSO implementation not working

[Shakthijuego]

Description

We using a gitea as SSO for internal Jenkins installation. However in the recent version of Gitea. Jenkins successfully redirected to the git login screen. However, when the user enters their credentials it won't redirect back to Jenkins. It stays on the same page. Interestingly if the user is already logged in to Gitea, SSO perfectly works. ie When user click login on Jenkins screen they are taken to gitea login and redirected back to Jenkins with successful logon.

Gitea Version

gitea-1.20.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

Behind ssl enabled nginx proxy. Possibly issue started after ssl enabled.

Database

SQLite

[Shakthijuego]

One more update. Issues seems to solved if we urlencode the redirect_uri. I am not sure if this is the bug from gitea side or jenkins side. Please advice. Jenkins seems doesn't have a option to configure the redirect url.

[wxiaoguang]

I think it will be fixed by

-> Use strict protocol check when redirect #29642

[lunny]

Closed by #29642

[wxiaoguang]

One more update. Issues seems to solved if we urlencode the redirect_uri. I am not sure if this is the bug from gitea side or jenkins side. Please advice. Jenkins seems doesn't have a option to configure the redirect url.

Actually Jenkins should encode the URL parameter correctly (every URL parameter should be escaped correctly), but Gitea could still tolerate the incorrect URL parameters .... so #29642 could fix the problem. The fix will be backported to 1.21, when the 1.21 nightly build is ready, you could take a try.

---

Update:

The 1.21 nightly (pre-1.21.8) is ready, it is a stable release and will become 1.21.8 soon. Please take a try, if the problem is still not resolved, please help to provide more details. Thank you!

Get 1.21 nightly:

• Docker: https://hub.docker.com/r/gitea/gitea/tags?page=1&name=nightly
• Binary: https://dl.gitea.com/gitea/1.21/