Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge User#GetDisplayName into User#DisplayName #31704

Open
delvh opened this issue Jul 25, 2024 · 1 comment
Open

Merge User#GetDisplayName into User#DisplayName #31704

delvh opened this issue Jul 25, 2024 · 1 comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@delvh
Copy link
Member

delvh commented Jul 25, 2024

Feature Description

As seen for example in #31687, we currently have two different methods to display a user name, and both doing similar things.
I don't see a reason why we should keep both.
I think keeping DisplayName and merging the body of GetDisplayName would make the most sense.

Or is there any reason why we need both methods, where we once ignore the [ui].DEFAULT_SHOW_FULL_NAME setting?

Screenshots

No response
@delvh delvh added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jul 25, 2024
@wolfogre
Copy link
Member

I agree. I believe it's just historical baggage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolfogre @delvh