Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal dialogs and consistency #3605

Closed
bugreport0 opened this issue Mar 1, 2018 · 8 comments
Closed

Modal dialogs and consistency #3605

bugreport0 opened this issue Mar 1, 2018 · 8 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI

Comments

@bugreport0
Copy link
Contributor

Description

There are multiple kinds of modal dialogs in Gitea with completely different semantics. They share strings in the translation file, blocking any attempt to have a decent user experience.

One kind is the 'delete' dialogs with a trashcan that offer 'No' and 'Yes' choices, see #3589. These can't be dismissed (cancelled) by clicking in an empty region.

Another kind is the 'Label Modification' [sic] dialog which acts completely different for some reason. This 'No' choice uses the 'No' string of the 'delete' dialogs, so I can't turn this into 'Cancel'. Good news is this one can be dismissed by clicking outside of it. But out of the blue this one sports a 'Modify √' button with a check-mark for fun.

I keep running into all kinds of user interface inconsistencies; I can't document all of them in the spare time that I have. Is there anyone even paying attention to Gitea as a whole? It feels like it's just different parts cobbled together. Sorry for the frustration.

Just dumping some other issues (I've got tons more) for future reference:

  • there is no way to tell you're filtering a repository issue list other than clicking all drop-down boxes
  • the 'new release' button on the releases page has a smaller size/font than other pages
  • button order in 'create release' and 'edit release' is different
  • clicking a milestone name opens its list of issues, clicking an issue name does nothing
  • on the installation page, checkboxes have flying tooltips, these are nowhere to be found elsewhere
  • the sub header text on the 'create milestone' and 'edit milestone' is different
  • same for the sub header on 'create release' and 'edit release' (I'm fixing both in my translation)
  • open milestones are colored green, closed milestones are colored red (see Issues and PR user interface colors #3590 too)
  • the 'Initial commit' string can't be changed from the translation file
  • the 'ZIP' and 'TAR.GZ' strings (releases page) can't be changed from the translation file

Screenshots

delete-yes

edit-label

@bugreport0
Copy link
Contributor Author

The 'Add Time' dialog decides to spice things up by randomly changing button order.

add-time

@thehowl
Copy link
Contributor

thehowl commented Mar 2, 2018

Is there anyone even paying attention to Gitea as a whole? It feels like it's just different parts cobbled together. Sorry for the frustration.

Yeah, you're not wrong. Both from a UX and a code point of view there should probably be more attention to the project as a whole, but in an open source project such as this one, where a lot of people come and go (myself included), it can be quite hard to have 'core developers' who keep track of everything and create cohesion in the project.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Mar 2, 2018
@lafriks lafriks added this to the 1.x.x milestone Mar 2, 2018
@bugreport0
Copy link
Contributor Author

@thehowl Thanks for the reply.

The entire thing is frustrating because Gitea is pretty amazing. It's an awesome standalone (self-hosted) development tool. But the UI and translation issues make it a diamond in the rough. Appreciated by those seeing its potential.

With a bit of polish and marketing, I'm pretty sure it could be one of the most popular open source development tools. It's easy. It's functional. It's great. Except for the paint job.

@thehowl
Copy link
Contributor

thehowl commented Mar 2, 2018

About that: I've actually worked on a blogpost for the next version (1.4) which is more appealing than the previous posts. I'm sure another pair of eyes to check on it wouldn't hurt, if you have the time :) go-gitea/blog#54

@bugreport0
Copy link
Contributor Author

bugreport0 commented Mar 3, 2018

@thehowl Took a look, sent a PR. Great work. I found the original style a bit over-excited, so I tried to reword it using the voice of my recent translation work.

Edit: I don't know how any of this works, but I think this is my PR to you: https://github.com/thehowl/blog-1/pull/1

@bugreport0
Copy link
Contributor Author

The repository settings 'Danger Zone' is again different, but looks very good for invasive operations (old wording shown here).

transfer-ownership

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 7, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 7, 2019
@lunny lunny removed this from the 1.x.x milestone Mar 20, 2023
@wxiaoguang
Copy link
Contributor

It has been improved by #24289 , no "black" dialog any more.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

5 participants