Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order code comments by review #4389

Closed
jonasfranz opened this issue Jul 6, 2018 · 1 comment · Fixed by #5104
Closed

Order code comments by review #4389

jonasfranz opened this issue Jul 6, 2018 · 1 comment · Fixed by #5104
Labels
type/enhancement An improvement of existing functionality
Milestone
1.6.0

Comments

@jonasfranz
Copy link
Member

It would be nice if code comments will be ordered by Review > Date. This will have the side-effect that we can show the complete conversation in the "conversations" tab. At the moment only the first comment of line gets shown at reviews in conversation tab.

My idea would be to introduce a new column at comment called reply_to containing the review id of the reply.

Blocked by #3748
@jonasfranz jonasfranz added type/enhancement An improvement of existing functionality status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Jul 6, 2018
@jonasfranz jonasfranz added this to the 1.x.x milestone Jul 6, 2018
@lafriks lafriks mentioned this issue Jul 6, 2018
Merged
23 tasks
@jonasfranz jonasfranz removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Aug 6, 2018
@jonasfranz
Copy link
Member Author

#3748 got implemented! Ready to get implemented.

This was referenced Oct 18, 2018
Closed
Merged
@lunny lunny modified the milestones: 1.x.x, 1.6.0 Oct 23, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Add comment replies jonasfranz/gitea
2 participants
@lunny @jonasfranz