Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jquery to 3.x #7422

Closed
lunny opened this issue Jul 11, 2019 · 4 comments · Fixed by #7425
Closed

Upgrade jquery to 3.x #7422

lunny opened this issue Jul 11, 2019 · 4 comments · Fixed by #7425
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@lunny
Copy link
Member

lunny commented Jul 11, 2019

Since 1.x and 2.x may include security problem, maybe we should upgrade to 3.x. And for compitable, we could use jQuery Migrate .
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jul 11, 2019
@sapk
Copy link
Member

sapk commented Jul 11, 2019

Or maybe drop it ? Is it used a lot ?

@lunny
Copy link
Member Author

lunny commented Jul 11, 2019

I think many javascript library depend on it.

@kjellkvinge
Copy link
Contributor

Related: #4384

@techknowlogick techknowlogick mentioned this issue Jul 11, 2019
Merged
@silverwind
Copy link
Member

silverwind commented Jul 11, 2019 •
edited
Loading

👍 on upgrade, 👎 on jquery.migrate, better to update any usage of deprecated/removed API than to rely on such bandaid solutions.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jQuery 3
4 participants
@lunny @silverwind @kjellkvinge @sapk