Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail - closing pull request generates same message as new pull request #8098

Closed
1 of 3 tasks
vakabus opened this issue Sep 5, 2019 · 2 comments · Fixed by #8329
Closed
1 of 3 tasks

Mail - closing pull request generates same message as new pull request #8098

vakabus opened this issue Sep 5, 2019 · 2 comments · Fixed by #8329
Labels
type/enhancement An improvement of existing functionality

Comments

@vakabus
Copy link
Contributor

vakabus commented Sep 5, 2019

  • Gitea version (or commit ref): c5ec66a
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No - I haven't received any emails from there
    • Not relevant

Description

When closing a pull request without a merge, an email notification is sent out with the same content as the message about new pull request. Nothing indicates, that the pull request has been closed. Expected behaviour would be, that the email would at least contain "pull request closed".

@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 5, 2019
@vakabus
Copy link
Contributor Author

vakabus commented Oct 5, 2019

Pretty much same issue with different action - when reopening PR, the first comment is sent out again. Expected would be a simple message just about reopening it.

@guillep2k
Copy link
Member

guillep2k commented Oct 5, 2019

Should be fixed by #8329 by improving the subject line. I think it's good to maintain the original issue content as the body of the mail if the subject is clear about what has been done.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants