Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright in footer is misleading #8725

Closed
fireglow opened this issue Oct 28, 2019 · 17 comments · Fixed by #9600
Closed

Copyright in footer is misleading #8725

fireglow opened this issue Oct 28, 2019 · 17 comments · Fixed by #9600
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@fireglow
Copy link

I think the "© Gitea" in templates/base/footer_content.tmpl#L4 is misleading.
While the page is rendered by Gitea, the actual content is not copyrighted by the Gitea project.

Other code-hosting sites like GitHub or GitLab do not show such a copyright.
Sites like nytimes.com or washingtonpost.com do, because the content displayed is actually theirs.

I therefore propose the wording to be changed to something clearer, like "Powered by Gitea", or "Generated by Gitea".

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 29, 2019
@MayMeow
Copy link
Contributor

MayMeow commented Oct 29, 2019

I can make PR if you decide which one sentence to use :)

@6543
Copy link
Member

6543 commented Oct 29, 2019

do we need "© Gitea" for leagal therms in fooder?

-> Licence MIT

@alexanderadam
Copy link

do we need "© Gitea" for leagal therms in fooder?

I strongly doubt it because Gitea is not a legal entity (like a company for example) so it probably can't hold any rights anyway.
AFAIK the particular authors own the rights of what they did. Which is true even if you don't write it on every code line you wrote because it's clarified in the the given license.

Kind of related but offtopic anyway. Click to show. So IMHO the license must be distributed as well and I'm not sure why the JS libraries are accessible as a link in the footer but the Gitea library itself is not.

But again, this would be another issue anyway and of course I'm not a lawyer. So nothing that I write might have any legal value.
Also the license situation of Gitea should be clarified anyway because it seems that it currently uses non-free dependencies.

@lunny
Copy link
Member

lunny commented Oct 29, 2019

In fact, that copyright is not related your codes on gitea instance. For example, you can see below in github. But github will not own the repositories' copyright on github. @fireglow I think you are wrong. Go to this page's bottom you will find it.

image

Even if we are not a company, but we have an organization. A person could hold copyright, a company could also, why not an organization?

@lunny lunny added the reviewed/wontfix The problem described in this issue/fixed in this pull request is not a problem we will fix label Oct 29, 2019
@alexanderadam
Copy link

Even if we are not a company, but we have an organization. A person could hold copyright, a company could also, why not an organization?

A legal organization can of course. I'm not sure whether this is a proper wording then.
Or can you just describe who is the organization? And is this organization represented on the Github organization?
Because if so this would mean only those 24 people who are part of the organization own the rights on Gitea.
Which is obviously not true because all of the authors of have some rights on it as the license says.

So to conclude: I would still say that © Gitea is absolutely not clear here because it's not clear who or what Gitea is from a legal perspective.
Even © The Gitea Authors would be clearer.

Otherwise I might have missed what the Gitea organization is and what it's statutes are.

@fireglow
Copy link
Author

Let's not get off track here, the issue is the "©", not the enitity name.
The "©" suggests that Gitea holds the copyright to the content of the page.

@fireglow
Copy link
Author

@lunny you are right, GitHub does that. One of my addons hides that.
GitHubs reasoning for that is outlined here: https://help.github.com/en/github/site-policy/github-terms-of-service#d-user-generated-content
That does not apply to self-hosted gitea instances.
Therefore I think the "notfix" label is premature.

@fireglow
Copy link
Author

@MayMeow I think "Powered by Gitea" would be fine, since it does more than merely generate code listings, like for example cgit (which uses "generated by").

@lafriks
Copy link
Member

lafriks commented Oct 29, 2019

Powered by should be ok imho

@lafriks lafriks removed the reviewed/wontfix The problem described in this issue/fixed in this pull request is not a problem we will fix label Oct 29, 2019
@lunny
Copy link
Member

lunny commented Oct 29, 2019

@alexanderadam maybe you are right. Since gitea is a non-registered organization, but we have organization join conditions and owners elections.

@ gitea will almost mean © The Gitea Authors. It's different from what you can see from other sites. The maintainers represents the gitea authors to do some community things.

@fireglow And the instances users could add theirs' term services to say what like github did since gitea support custom pages.

@0x5c
Copy link
Contributor

0x5c commented Oct 31, 2019

I fixed it, and this is what it looks now
image

I do not know how to use i18n though. Is it simply be a case of replacing the text with {{.i18n.Tr "powered-by"}} and adding a corresponding string to the default language file?

Also, I wonder if Gitea in that text should be a link to gitea.io:
image

Further, should there be a separator between Powered by Gitea and Version?

@lafriks
Copy link
Member

lafriks commented Oct 31, 2019

It should probably be something like this:

Powered by Gitea version 1.11...

where Gitea is link to https://gitea.io/ and two translatable strings Powered by and version

@lafriks
Copy link
Member

lafriks commented Oct 31, 2019

I do not know how to use i18n though. Is it simply be a case of replacing the text with {{.i18n.Tr "powered-by"}} and adding a corresponding string to the default language file?

Yes, only in en-US locale

@0x5c
Copy link
Contributor

0x5c commented Oct 31, 2019

It should probably be something like this:

Powered by Gitea version 1.11...

where Gitea is link to https://gitea.io/ and two translatable strings Powered by and version

That sounds good

Yes, only in en-US locale

Good

@0x5c
Copy link
Contributor

0x5c commented Oct 31, 2019

Looking at the template, it seems that Version is already a translatable string

@0x5c
Copy link
Contributor

0x5c commented Oct 31, 2019

Since version is a translatable string, but it is capitalised (and likely used in other places as-is), should a new one be created?

EDIT: might as-well add that making Powered by translatable worked first try 👍

@0x5c
Copy link
Contributor

0x5c commented Oct 31, 2019

@alexanderadam I just realised that you had already made a PR. My version of the fix is already an i18n string, and has Gitea be a link to gitea.io.

Do you want to continue with your PR or shall I take over?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants