-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Button to apply diff comments to PRs #9388
Comments
It would have to either be a git formatted diff or even better patch, or else be attached to a file somehow. |
@guillep2k you could link this issue to #8659 (just noticed ...) |
update: #17902 did add support in terms of api 🎉 |
Did you mean to support |
suggestion support as per github, would be nice but is likely harder to implement.a diff is easier to implement for the start as you can use the described apiexample: diff --git a/templates/admin/auth/list.tmpl b/templates/admin/auth/list.tmpl
index b4a703e41..64db93a3e 100644
--- a/templates/admin/auth/list.tmpl
+++ b/templates/admin/auth/list.tmpl
@@ -10,7 +10,7 @@
</div>
</h4>
<div class="ui attached table segment">
- <table class="ui very basic striped table unstackable">
+ <table class="ui two basic striped table unstackable">
<thead>
<tr>
<th>ID</th> |
☝️ suggestion support would be also nice, but you have to create a diff/patch form the infos first ... (what was original there ... |
For apply a patch, isn't it implemented in #17902? We just add a form in UI but not upload a file to do that? |
It would be nice if this also applied to |
if you leaf a code-block commit with: ```diff ...
show a button to commit the diff to the PR
like suggestions in PR review comments but more powerful
for those who are interesting to implement it:
The text was updated successfully, but these errors were encountered: