Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note: refacotr models/webhook.go #9692

Closed
6543 opened this issue Jan 10, 2020 · 9 comments
Closed

note: refacotr models/webhook.go #9692

6543 opened this issue Jan 10, 2020 · 9 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@6543
Copy link
Member

6543 commented Jan 10, 2020

note for me:

refactor models/webhook.go to combine GetWebhooksByRepoID and GetWebhooksByOrgID to `GetWebhooks(opts SearchWebhooksOptions) .,...

// SearchWebhooksOptions holds the search options
type SearchWebhooksOptions struct {
...
@6543
Copy link
Member Author

6543 commented Jan 10, 2020

@spawn2kill ping

@6543
Copy link
Member Author

6543 commented Jan 10, 2020

and we can also include GetActiveWebhooksByOrgID

@hilariocoelho
Copy link
Contributor

I'll take this. If you find any more cases like this add to this issue please.

@stale
Copy link

stale bot commented Mar 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 10, 2020
@6543
Copy link
Member Author

6543 commented Mar 11, 2020

@spawn2kill are you still interested in it?

@stale stale bot removed the issue/stale label Mar 11, 2020
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Mar 11, 2020
@alexanderadam
Copy link

I'm not sure whether this could be related but it would be great if it would be made with focus on #1089, if someone decides to refactor models/webhook.go.

@6543
Copy link
Member Author

6543 commented Mar 13, 2020

@alexanderadam this is out of scope ...

@alexanderadam
Copy link

Okay, no problem 👍 I just wanted to mention it, in case it would be suitable.

@6543
Copy link
Member Author

6543 commented Sep 17, 2020

Did have a closer look into codebase: combining would have only minimal dedublication and would add complxity so this wont happen for now

@6543 6543 closed this as completed Sep 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

4 participants