-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
note: refacotr models/webhook.go #9692
Comments
@spawn2kill ping |
and we can also include GetActiveWebhooksByOrgID |
I'll take this. If you find any more cases like this add to this issue please. |
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions. |
@spawn2kill are you still interested in it? |
I'm not sure whether this could be related but it would be great if it would be made with focus on #1089, if someone decides to refactor |
@alexanderadam this is out of scope ... |
Okay, no problem 👍 I just wanted to mention it, in case it would be suitable. |
Did have a closer look into codebase: combining would have only minimal dedublication and would add complxity so this wont happen for now |
note for me:
refactor models/webhook.go to combine GetWebhooksByRepoID and GetWebhooksByOrgID to `GetWebhooks(opts SearchWebhooksOptions) .,...
The text was updated successfully, but these errors were encountered: