Fix sender of issue notifications #2

strk · 2016-11-02T17:24:19Z

It is the FROM field in mailer configuration that needs be used,
not the USER field, which is for authentication.

Migrated from gogs/gogs#3616

tboerger · 2016-11-02T18:04:50Z

LGTM, but needs to be rebased.

strk · 2016-11-02T19:35:22Z

Sorry, I'm confused, should this target develop or master branch ?

bkcsoft · 2016-11-02T19:36:31Z

according to consensus in Gitter, it should go into master 🙂

joubertredrat · 2016-11-02T19:39:18Z

@bkcsoft 😱 is possible to change target or only with new PR?

bkcsoft · 2016-11-02T19:50:14Z

The others that has been merged targeted develop, so leave it at that :)

It is the FROM field in mailer configuration that needs be used, not the USER field, which is for authentication. Closes gogs#3615

tboerger · 2016-11-02T20:07:37Z

.gopmfile

@@ -35,7 +35,7 @@ github.com/nfnt/resize = commit:891127d
 github.com/russross/blackfriday = commit:93622da
 github.com/satori/go.uuid = commit:0aa62d5
 github.com/sergi/go-diff = commit:ec7fdbb
-github.com/strk/go-libravatar = commit:5eed7bf
+strk.kbt.io/projects/go/libravatar = commit:5eed7bf


Not related to this pr

strk · 2016-11-02T20:10:51Z

It was a bogus base (master) -- now based on develop branch, should be fine.

tboerger · 2016-11-02T20:17:58Z

LGTM

andreynering · 2016-11-02T21:36:10Z

Please reopen this against master

lunny · 2016-11-03T08:00:43Z

LGTM

CloneAddr was being used as OriginalURL. Now passing OriginalURL through from the form and saving it.

* 6543 suggestions * fix

Fix + Extend Tests

* First stab at a Gitlab migrations interface. * Modify JS to show migration for Gitlab * Properly strip out #gitlab tag from repo name * Working Gitlab migrations! Still need to figure out how to hide tokens/etc from showing up in opts.CloneAddr * Try #2 at trying to hide credentials. CloneAddr was being used as OriginalURL. Now passing OriginalURL through from the form and saving it. * Add go-gitlab dependency * Vendor go-gitlab * Use gitlab.BasicAuthClient Correct CloneURL. This should be functioning! Previous commits fixed "Migrated from" from including the migration credentials. * Replaced repoPath with repoID globally. RepoID is grabbed in NewGitlabDownloader * Logging touchup * Properly set private repo status. Properly set milestone deadline time. Consistently use Gitlab username for 'Name'. * Add go-gitlab vendor cache * Fix PR migrations: - Count of issues is kept to set a non-conflicting PR.ID - Bool is used to tell whether to fetch Issue or PR comments * Ensure merged PRs are closed and set with the proper time * Remove copyright and some commented code * Rip out '#gitlab' based self-hosted Gitlab support * Hide given credentials for migrated repos. CloneAddr was being saved as OriginalURL. Now passing OriginalURL through from the form and saving it in it's place * Use asset.URL directly, no point in parsing. Opened PRs should fall through to false. * Fix importing Milestones. Allow importing using Personal Tokens or anonymous access. * Fix Gitlab Milestone migration if DueDate isn't set * Empty Milestone due dates properly return nil, not zero time * Add GITLAB_READ_TOKEN to drone unit-test step * Add working gitlab_test.go. A Personal Access Token, given in env variable GITLAB_READ_TOKEN is required to run the test. * Fix linting issues * Add modified JS files * Remove pre-build JS files * Only merged PRs are marged as merged/closed * Test topics * Skip test if gitlab is inaccessible * Grab personal token from username, not password. Matches Github migration implementation * Add SetContext() to GitlabDownloader. * Checking Updated field in Issues. * Actually fetch Issue Updated time from Gitlab * Add Gitlab migration GetReviews() stub * Fix Patch and Clone URLs * check Updated too * fix mod * make vendor with go1.14 Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

* First stab at a Gitlab migrations interface. * Modify JS to show migration for Gitlab * Properly strip out #gitlab tag from repo name * Working Gitlab migrations! Still need to figure out how to hide tokens/etc from showing up in opts.CloneAddr * Try go-gitea#2 at trying to hide credentials. CloneAddr was being used as OriginalURL. Now passing OriginalURL through from the form and saving it. * Add go-gitlab dependency * Vendor go-gitlab * Use gitlab.BasicAuthClient Correct CloneURL. This should be functioning! Previous commits fixed "Migrated from" from including the migration credentials. * Replaced repoPath with repoID globally. RepoID is grabbed in NewGitlabDownloader * Logging touchup * Properly set private repo status. Properly set milestone deadline time. Consistently use Gitlab username for 'Name'. * Add go-gitlab vendor cache * Fix PR migrations: - Count of issues is kept to set a non-conflicting PR.ID - Bool is used to tell whether to fetch Issue or PR comments * Ensure merged PRs are closed and set with the proper time * Remove copyright and some commented code * Rip out '#gitlab' based self-hosted Gitlab support * Hide given credentials for migrated repos. CloneAddr was being saved as OriginalURL. Now passing OriginalURL through from the form and saving it in it's place * Use asset.URL directly, no point in parsing. Opened PRs should fall through to false. * Fix importing Milestones. Allow importing using Personal Tokens or anonymous access. * Fix Gitlab Milestone migration if DueDate isn't set * Empty Milestone due dates properly return nil, not zero time * Add GITLAB_READ_TOKEN to drone unit-test step * Add working gitlab_test.go. A Personal Access Token, given in env variable GITLAB_READ_TOKEN is required to run the test. * Fix linting issues * Add modified JS files * Remove pre-build JS files * Only merged PRs are marged as merged/closed * Test topics * Skip test if gitlab is inaccessible * Grab personal token from username, not password. Matches Github migration implementation * Add SetContext() to GitlabDownloader. * Checking Updated field in Issues. * Actually fetch Issue Updated time from Gitlab * Add Gitlab migration GetReviews() stub * Fix Patch and Clone URLs * check Updated too * fix mod * make vendor with go1.14 Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Merge branch 'master' of https://github.com/go-gitea/gitea

tboerger added this to the 1.0.0 milestone Nov 2, 2016

strk force-pushed the proper-from-on-issue-mail branch 2 times, most recently from fb4a8e6 to 20c1740 Compare November 2, 2016 19:25

Fix sender of issue notifications

af03d00

It is the FROM field in mailer configuration that needs be used, not the USER field, which is for authentication. Closes gogs#3615

strk force-pushed the proper-from-on-issue-mail branch from 20c1740 to af03d00 Compare November 2, 2016 20:01

tboerger suggested changes Nov 2, 2016

View reviewed changes

strk changed the base branch from master to develop November 2, 2016 20:10

tboerger approved these changes Nov 2, 2016

View reviewed changes

lunny merged commit d8de2be into go-gitea:develop Nov 3, 2016

tboerger added the type/bug label Nov 3, 2016

strk deleted the proper-from-on-issue-mail branch November 3, 2016 16:04

strk mentioned this pull request Nov 24, 2016

Mail notifications have invalid addresses gogs/gogs#3659

Closed

6 tasks

tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016

kolaente mentioned this pull request Jul 22, 2017

Dependencies for issues #2196

Closed

kolaente mentioned this pull request Sep 17, 2017

Added dependencies for issues (#2196) #2531

Merged

r-pufky mentioned this pull request Jun 10, 2018

docker https fails with web_graceful [E] Failed to load https cert file 0.0.0.0:3000 : open : no such file or directory #4196

Closed

7 tasks

filipnavara mentioned this pull request Sep 23, 2018

Slow page loads with a large repo #491

Closed

pcopissa mentioned this pull request Oct 18, 2018

'git push' over SSH does not close issues, but does over HTTP(S). #5107

Closed

6 tasks

wofnull mentioned this pull request Jan 22, 2019

SQLite - Unknown col "is_empty" in index is_bare in all Versions after 18.01.2019 #5797

Closed

7 tasks

tklein23 mentioned this pull request Mar 7, 2019

"Ghost" user in issue list points 404 page, but should not be clickable #6270

Closed

3 tasks

giter mentioned this pull request Mar 19, 2019

Unable to migrate from version 1.7.3 to version 1.8.0-rc1 #6371

Closed

7 tasks

marcsiq mentioned this pull request Apr 16, 2019

Text replacing issues in post requests #6655

Closed

7 tasks

alexmejiaec mentioned this pull request Apr 22, 2019

Unable to migrate from version 1.7.4 to version 1.8.0 #6707

Closed

6 tasks

joestr mentioned this pull request Jun 4, 2019

No link to external issue tracker in commit message #7121

Closed

7 tasks

flobee mentioned this pull request Jul 12, 2019

issue tags eg "#1" vs "someprefix#1" #7438

Closed

This was referenced Aug 13, 2019

API: Allow setting the issue number when creating an issue #7790

Closed

Implement index parameter on api/create issue #7876

Closed

Jookia mentioned this pull request Oct 23, 2019

a11y: Improve accessibility of dropdown menus #8638

Merged

gewure mentioned this pull request Nov 8, 2019

How do I enable password reset ? #2247

Closed

aqtrans referenced this pull request in aqtrans/gitea Nov 20, 2019

Try #2 at trying to hide credentials.

eaf52a4

CloneAddr was being used as OriginalURL. Now passing OriginalURL through from the form and saving it.

ohsayan mentioned this pull request Dec 4, 2019

Bug: Issue and PR are given same counters when using SQLite3 #9249

Closed

6543 referenced this pull request in 6543-forks/gitea Feb 8, 2020

Kanban board suggestions (#2)

338e8bb

* 6543 suggestions * fix

johannesrauch mentioned this pull request Mar 18, 2020

Impossible to pull / push via ssh gitea #5497

Closed

7 tasks

6543 referenced this pull request in 6543-forks/gitea Apr 10, 2020

Merge pull request #2 from 6543-forks/gitlab-m-fix

a224698

Fix + Extend Tests

somera mentioned this pull request Jun 18, 2020

Update to 1.12.0: #11966

Closed

7 tasks

silverwind referenced this pull request in silverwind/gitea Aug 26, 2020

Merge pull request #2 from go-gitea/master

59f694b

Merge branch 'master' of https://github.com/go-gitea/gitea

jsreynolds mentioned this pull request Sep 11, 2020

"View File" link creates 404 in particular scenarios #12816

Closed

7 tasks

ramasoft-dv mentioned this pull request Oct 28, 2020

[Bug] PullRequest: merge base branch into feature branch cause "broken fork" and other errors #12740

Closed

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sender of issue notifications #2

Fix sender of issue notifications #2

strk commented Nov 2, 2016

tboerger commented Nov 2, 2016

strk commented Nov 2, 2016

bkcsoft commented Nov 2, 2016

joubertredrat commented Nov 2, 2016

bkcsoft commented Nov 2, 2016

tboerger Nov 2, 2016

strk commented Nov 2, 2016

tboerger commented Nov 2, 2016

andreynering commented Nov 2, 2016

lunny commented Nov 3, 2016

Fix sender of issue notifications #2

Fix sender of issue notifications #2

Conversation

strk commented Nov 2, 2016

tboerger commented Nov 2, 2016

strk commented Nov 2, 2016

bkcsoft commented Nov 2, 2016

joubertredrat commented Nov 2, 2016

bkcsoft commented Nov 2, 2016

tboerger Nov 2, 2016

Choose a reason for hiding this comment

strk commented Nov 2, 2016

tboerger commented Nov 2, 2016

andreynering commented Nov 2, 2016

lunny commented Nov 3, 2016