From 01210675c90f69d175b598ff34dcc5e55bb36f94 Mon Sep 17 00:00:00 2001 From: Andrew Thornton Date: Sun, 15 Jan 2023 11:56:33 +0000 Subject: [PATCH] Fix environments for KaTeX and error reporting In #22447 it was noticed that display environments were not working correctly. This was due to the setting displayMode not being set. Further it was noticed that the error was not being displayed correctly. This PR fixes both of these issues by forcibly setting the displayMode setting and corrects an error in displayError. Fix #22447 Signed-off-by: Andrew Thornton --- web_src/js/markup/math.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/web_src/js/markup/math.js b/web_src/js/markup/math.js index d4e40d5be2e34..cfd058c93cc8e 100644 --- a/web_src/js/markup/math.js +++ b/web_src/js/markup/math.js @@ -1,6 +1,6 @@ function displayError(el, err) { const target = targetElement(el); - target.remove('is-loading'); + target.classList.remove('is-loading'); const errorNode = document.createElement('div'); errorNode.setAttribute('class', 'ui message error markup-block-error mono'); errorNode.textContent = err.str || err.message || String(err); @@ -23,13 +23,15 @@ export async function renderMath() { for (const el of els) { const source = el.textContent; - const nodeName = el.classList.contains('display') ? 'p' : 'span'; + const displayMode = el.classList.contains('display'); + const nodeName = displayMode ? 'p' : 'span'; try { const tempEl = document.createElement(nodeName); katex.render(source, tempEl, { maxSize: 25, maxExpand: 50, + displayMode, }); targetElement(el).replaceWith(tempEl); } catch (error) {