Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some flex layouts #26649

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Improve some flex layouts #26649

merged 3 commits into from
Aug 22, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Aug 22, 2023 •
edited
Loading

Fix #26617

  1. Separate the "flex-list" examples into a dedicated template, and add some more examples
  2. Use flex-basis instead of flex-shrink for flex-item-trailing, to avoid wrapping the texts too aggressively
  3. Some flex-wrap: wrap; are removed, see the screenshot

Screenshot for 1

image

image

Screenshot for 2

image

image

image

image

Screenshot for 3

Before:

image

After:

image

@wxiaoguang wxiaoguang added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Aug 22, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 22, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 22, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2023
This was referenced Aug 22, 2023
Closed
Closed
@yp05327
Copy link
Contributor

yp05327 commented Aug 22, 2023

image

@wxiaoguang
Copy link
Contributor Author

See 9001757

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 22, 2023
@yp05327
Copy link
Contributor

yp05327 commented Aug 22, 2023

image
This looks good.

image
👀

image
It seems that GitHub also have some problems in this place.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2023
denyskon
denyskon approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I didn't even have time yesterday to take a look, but your fix looks good 👍

@wxiaoguang wxiaoguang merged commit 7934602 into go-gitea:main Aug 22, 2023
@wxiaoguang wxiaoguang deleted the fix-flex-list branch August 22, 2023 04:57
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 22, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
b29d031 
* upstream/main:
  Improve show role (go-gitea#26621)
  Improve some flex layouts (go-gitea#26649)
  feat: implement organization secret creation API (go-gitea#26566)
  Check disabled workflow when rerun jobs (go-gitea#26535)
@wxiaoguang wxiaoguang mentioned this pull request Aug 23, 2023
Merged
wxiaoguang added a commit that referenced this pull request Aug 23, 2023
@wxiaoguang
More improvements for the "flex list" and the dashboard list (#26675)
e4b2bdf 
Follow #26649 and #25790 and add one more example (text truncate) in the devtest page
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denyskon denyskon denyskon approved these changes

@yp05327 yp05327 yp05327 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

UI: settings page style error
5 participants
@wxiaoguang @yp05327 @lunny @denyskon @GiteaBot