Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix review bar misalignment #26711

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix review bar misalignment #26711

merged 1 commit into from
Aug 24, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Aug 24, 2023 •
edited
Loading

Before

image

After

image

image

image

@wxiaoguang wxiaoguang added the topic/ui Change the appearance of the Gitea UI label Aug 24, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 24, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 24, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2023
denyskon
denyskon approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see style fixes that even make the code more readable :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2023
@wxiaoguang wxiaoguang merged commit 390ec61 into go-gitea:main Aug 24, 2023
@wxiaoguang wxiaoguang deleted the fix-review-ui branch August 24, 2023 15:46
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 25, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9a3215d 
* giteaofficial/main:
  Fix review bar misalignment (go-gitea#26711)
  Use "small-loading-icon" insead of "btn-octicon is-loading" (go-gitea#26710)
  Improve Image Diff UI (go-gitea#26696)
  Make issue template field template access correct template data (go-gitea#26698)
  add Upload URL to release API (go-gitea#26663)
  Add merge files files to GetCommitFileStatus (go-gitea#20515)
  PATCH branch-protection updates check list even when checks are disabled (go-gitea#26351)
  Add `member`, `collaborator`, `contributor`, and `first-time contributor` roles and tooltips (go-gitea#26658)
  chore(actions): support cron schedule task (go-gitea#26655)
@wxiaoguang wxiaoguang mentioned this pull request Aug 25, 2023
Closed
@wxiaoguang
Copy link
Contributor Author

-> Fix review UI #27322

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denyskon denyskon denyskon approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @denyskon @GiteaBot