Remove set tabindex on view issue #27892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
earl-warren
commented
Nov 3, 2023
earl-warren
commented
- Remove the set tabindex and instead let the browser figure out the correct tab order.
- Resolves https://codeberg.org/forgejo/forgejo/issues/1626
- Remove the set tabindex and instead let the browser figure out the correct tab order. - Resolves https://codeberg.org/forgejo/forgejo/issues/1626
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
the
modifies/templates
denyskon
approved these changes
Nov 3, 2023
GiteaBot
added
lgtm/need 1
|
@wxiaoguang Since you have sent #26733, maybe you can take a review. |
|
I think this PR is still incomplete. Would you like to improve it and have a complete fix?
|
wxiaoguang
approved these changes
Nov 3, 2023
GiteaBot
added
lgtm/done
wxiaoguang
added
reviewed/wait-merge
|
I was unable to create a backport for 1.20. @earl-warren, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 3, 2023
Remove the "tabindex" from some form buttons on the "diff box" / "issue view content" page, let the browser use the default tab order. --------- Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
removed
the
reviewed/wait-merge
lunny
pushed a commit
that referenced
this pull request
Nov 3, 2023
Backport #27892 by @earl-warren - Remove the set tabindex and instead let the browser figure out the correct tab order. - Resolves https://codeberg.org/forgejo/forgejo/issues/1626 Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 6, 2023
* upstream/main: Fix edit topic UI (go-gitea#27925) Unify two factor check (go-gitea#27915) Revert go-gitea#27870 (go-gitea#27917) Fix JS NPE when viewing specific range of PR commits (go-gitea#27912) Install poetry dependencies with --no-root (go-gitea#27919) Show correct commit sha when viewing single commit diff (go-gitea#27916) Fix 500 when deleting a dismissed review (go-gitea#27903) Remove action runners on user deletion (go-gitea#27902) Remove SSH workaround (go-gitea#27893) Remove "tabindex" from some form buttons (go-gitea#27892) Refactor the function RemoveOrgUser (go-gitea#27582) Fix DownloadFunc when migrating releases (go-gitea#27887)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Remove the "tabindex" from some form buttons on the "diff box" / "issue view content" page, let the browser use the default tab order. --------- Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.