Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery from the repo release form #29225

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Remove jQuery from the repo release form #29225

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11d700c
Remove jQuery from the repo release form
yardenshoham Feb 17, 2024
29cf6cd
Update web_src/js/features/repo-release.js
yardenshoham Feb 17, 2024
2c4615a
Merge branch 'main' into repo-release-jquery
GiteaBot Feb 17, 2024
2abf96e
Merge branch 'main' into repo-release-jquery
GiteaBot Feb 17, 2024
3bfcfff
Merge branch 'main' into repo-release-jquery
GiteaBot Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions web_src/js/features/repo-release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import $ from 'jquery';
import {hideElem, showElem} from '../utils/dom.js';
import {initComboMarkdownEditor} from './comp/ComboMarkdownEditor.js';

export function initRepoRelease() {
$(document).on('click', '.remove-rel-attach', function() {
const uuid = $(this).data('uuid');
const id = $(this).data('id');
$(`input[name='attachment-del-${uuid}']`).attr('value', true);
hideElem($(`#attachment-${id}`));
document.addEventListener('click', (e) => {
if (e.target.matches('.remove-rel-attach')) {
const uuid = e.target.getAttribute('data-uuid');
const id = e.target.getAttribute('data-id');
document.querySelector(`input[name='attachment-del-${uuid}']`).value = 'true';
hideElem(`#attachment-${id}`);
}
delvh marked this conversation as resolved.
Show resolved Hide resolved
});
}

export function initRepoReleaseNew() {
const $repoReleaseNew = $('.repository.new.release');
if (!$repoReleaseNew.length) return;
if (!document.querySelector('.repository.new.release')) return;

initTagNameEditor();
initRepoReleaseEditor();
Expand Down Expand Up @@ -45,9 +45,9 @@ function initTagNameEditor() {
}

function initRepoReleaseEditor() {
const $editor = $('.repository.new.release .combo-markdown-editor');
if ($editor.length === 0) {
const editor = document.querySelector('.repository.new.release .combo-markdown-editor');
if (!editor) {
return;
}
const _promise = initComboMarkdownEditor($editor);
initComboMarkdownEditor(editor);
}
Loading