Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organziation webhook API endpoints #372

Merged
merged 2 commits into from
Dec 25, 2016
Merged

Organziation webhook API endpoints #372

merged 2 commits into from
Dec 25, 2016

Conversation

ethantkoenig
Copy link
Member

Adds the following API endpoints:

  • GET repos/:owner/:reponame/hooks/:id: Get a single repo webhook
  • GET orgs/:orgname/hooks: Get an organization's webhooks
  • GET orgs/:orgname/hooks/:id: Get a single organization webhook
  • POST orgs/:orgname/hooks: Create an organization webhook
  • PATCH orgs/:orgname/hooks/:id: Update an organization webhook
  • DELETE orgs/:orgname/hooks/:id: Delete an organization webhook

All these endpoints exists in the Github API (see orgs, repos)

I've added routers/api/v1/utils/hook.go, which contains functionality that is shared between repo webhook and organization webhook endpoints.

@lunny lunny added type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Dec 10, 2016
@tboerger tboerger modified the milestones: 1.0.0, 1.1.0 Dec 10, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 11, 2016

👍 at moving shared functions to utils/ :)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 11, 2016

One thing missing here though is the relevant functions into go-sdk, after that vendor those in this PR 🙂

@ethantkoenig ethantkoenig mentioned this pull request Dec 12, 2016
Merged
@ethantkoenig
Copy link
Member Author

@bkcsoft go-gitea/go-sdk#26

@ethantkoenig ethantkoenig force-pushed the api/org_webhooks branch 2 times, most recently from 2d7e5b8 to 6fbf66b Compare December 14, 2016 20:49
@ethantkoenig ethantkoenig force-pushed the api/org_webhooks branch 2 times, most recently from 97a9505 to e0a667b Compare December 22, 2016 14:56
@lunny
Copy link
Member

lunny commented Dec 24, 2016

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 24, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 25, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 25, 2016
@bkcsoft bkcsoft merged commit 8de8ec0 into go-gitea:master Dec 25, 2016
@ethantkoenig ethantkoenig deleted the api/org_webhooks branch December 27, 2016 15:12
@lunny lunny added the modifies/api This PR adds API routes or modifies them label Jan 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ethantkoenig @bkcsoft @lunny @tboerger