From 4979a12f909f27f86585dec62a1d40dac7ed702b Mon Sep 17 00:00:00 2001 From: Jookia <166291@gmail.com> Date: Mon, 14 Oct 2019 14:35:08 +1100 Subject: [PATCH 1/7] js: Fixup dropdown menu items tabindex on load This is a bit of a workaround, but it saves editing a ton of HTML for now. --- public/js/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/public/js/index.js b/public/js/index.js index 8a85ad91579e5..5cc623c7b3e07 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -3147,3 +3147,5 @@ function onOAuthLoginClick() { oauthNav.show(); },5000); } + +$("div.dropdown").find("a.item").attr("tabindex", "-1"); From 9c8178076c2ae22fba99781a1879ef7de0176299 Mon Sep 17 00:00:00 2001 From: Jookia <166291@gmail.com> Date: Mon, 14 Oct 2019 14:35:49 +1100 Subject: [PATCH 2/7] js: Fix up dropdown menu icon tabindex on load --- public/js/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/public/js/index.js b/public/js/index.js index 5cc623c7b3e07..e790d5a7aa7f9 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -3149,3 +3149,4 @@ function onOAuthLoginClick() { } $("div.dropdown").find("a.item").attr("tabindex", "-1"); +$("div.dropdown").find("i.dropdown.icon").attr("tabindex", "-1"); From 678b01c865d278daa100df6da49499bdb4423246 Mon Sep 17 00:00:00 2001 From: Jookia <166291@gmail.com> Date: Mon, 14 Oct 2019 14:57:24 +1100 Subject: [PATCH 3/7] js: Set all buttons tabindex=0 --- public/js/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/public/js/index.js b/public/js/index.js index e790d5a7aa7f9..c91d926cd05ed 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -3148,5 +3148,6 @@ function onOAuthLoginClick() { },5000); } +$("div.button").attr("tabindex", "0"); $("div.dropdown").find("a.item").attr("tabindex", "-1"); $("div.dropdown").find("i.dropdown.icon").attr("tabindex", "-1"); From d0b9092edf7c704d8a7f69e821340db59fa8efd0 Mon Sep 17 00:00:00 2001 From: Jookia <166291@gmail.com> Date: Mon, 14 Oct 2019 15:05:50 +1100 Subject: [PATCH 4/7] js: Don't override existing tabindex attributes --- public/js/index.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/public/js/index.js b/public/js/index.js index c91d926cd05ed..f4c3384b30f5d 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -3148,6 +3148,6 @@ function onOAuthLoginClick() { },5000); } -$("div.button").attr("tabindex", "0"); -$("div.dropdown").find("a.item").attr("tabindex", "-1"); -$("div.dropdown").find("i.dropdown.icon").attr("tabindex", "-1"); +$("div.button:not([tabindex])").attr("tabindex", "0"); +$("div.dropdown").find("a.item:not([tabindex])").attr("tabindex", "-1"); +$("div.dropdown").find("i.dropdown.icon:not([tabindex])").attr("tabindex", "-1"); From 820f5994863006856d896e02b3e43552d44b7f19 Mon Sep 17 00:00:00 2001 From: Jookia <166291@gmail.com> Date: Thu, 17 Oct 2019 11:39:58 +1100 Subject: [PATCH 5/7] js: Add role=menuitem to non-search dropdowns This signals to Orca to send keydown events for all keys, so now Orca's caret mode will properly allow navigation through menus. --- public/js/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/public/js/index.js b/public/js/index.js index f4c3384b30f5d..6749d6281df8b 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -3149,5 +3149,6 @@ function onOAuthLoginClick() { } $("div.button:not([tabindex])").attr("tabindex", "0"); +$("div.dropdown:not(div.search)").attr("role", "menuitem"); $("div.dropdown").find("a.item:not([tabindex])").attr("tabindex", "-1"); $("div.dropdown").find("i.dropdown.icon:not([tabindex])").attr("tabindex", "-1"); From 18b30b1e8b70ac5980f42f382017815c8bcdfda7 Mon Sep 17 00:00:00 2001 From: Jookia <166291@gmail.com> Date: Thu, 17 Oct 2019 11:51:27 +1100 Subject: [PATCH 6/7] dashboard: Flatten the dashboard context switch menu This makes the 'create organization' link keyboard accessible --- templates/user/dashboard/navbar.tmpl | 2 -- 1 file changed, 2 deletions(-) diff --git a/templates/user/dashboard/navbar.tmpl b/templates/user/dashboard/navbar.tmpl index 25c45325a64cd..45f7f97bd14bc 100644 --- a/templates/user/dashboard/navbar.tmpl +++ b/templates/user/dashboard/navbar.tmpl @@ -11,7 +11,6 @@