Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for exponentialMovingAverage #779

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Various fixes for exponentialMovingAverage #779

merged 1 commit into from
Jul 7, 2023

Conversation

npazosmendez
Copy link
Collaborator

Multiple fixes for exponentialMovingAverage:

  • Adjust the from to take the preview window of the series when getting the argument. This bug was previously producing empty results in some scenarios.
  • Correctly calculate the previewSeconds when the window size is an integer, and refetch the data as necessary
  • Correctly calculate the constant used for the window, which is calculated differently depending on whether the window is an integer or a string interval. See graphite web
  • Default to zero when the preview average (of the window) is NaN. See Graphite Web.
  • Set Start Time like Graphite Web does.

@Civil Civil enabled auto-merge July 7, 2023 20:02
@Civil Civil requested a review from carrieedwards July 7, 2023 20:02
@Civil Civil added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit e4f13dd Jul 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants