Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for older go versions #30

Open
kishaningithub opened this issue Aug 8, 2021 · 2 comments
Open

Dropping support for older go versions #30

kishaningithub opened this issue Aug 8, 2021 · 2 comments

Comments

@kishaningithub
Copy link
Contributor

kishaningithub commented Aug 8, 2021

I see we are supporting a lot of go versions

I think we can drop support for versions prior to go modules

#25 (comment)

Keeping the above PR in mind we can keep the minimum to go 1.12

@ChrisHines
Copy link
Member

I think that's fair. I have been working on some improvements along those lines in the background, time permitting. The challenge has been that as I worked on expanding the test coverage to handle some of the newer features in Go I discovered that it is tricky to get this package to produce consistent results with various combinations of GOPATH vs. modules and -trimpath or no -trimpath. One of my ideas to work around those challenges involves taking advantage of runtime/debug.BuildInfo (added in Go 1.12), to figure out which parts of the paths are the module path. But testing that has been complicated by golang/go#33976.

@kishaningithub
Copy link
Contributor Author

kishaningithub commented Dec 6, 2021

In my opinion we can keep the go min version as 1.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants