Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetIndent does not document that it requires a value in [2,9] #501

Open
tliron opened this issue Sep 6, 2019 · 0 comments
Open

SetIndent does not document that it requires a value in [2,9] #501

tliron opened this issue Sep 6, 2019 · 0 comments

Comments

@tliron
Copy link

tliron commented Sep 6, 2019

The code that enforces it is here, where it defaults to 2 if a bad value is provided.

However, this is not documented in SetIndent.

A related question is why is this limit even necessary? Why not allow an indent value of 1, for example, for maximum savings in some situations? Is this something that's required in the YAML spec?
mkmik pushed a commit to mkmik/knot8 that referenced this issue May 12, 2020
Indentation detection via preprocessing
ffe1fb8 
This is hackish impl but it correctly indents multiline scalars at any indentation level
(with workaround for go-yaml/yaml#501)
@mikefarah mikefarah mentioned this issue May 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tliron